Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: extensions/common/manifest_constants.cc

Issue 226663003: Allow content script insertion on about:-URLs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use matches_about_blank key instead of about:* permission. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/manifest_constants.cc
diff --git a/extensions/common/manifest_constants.cc b/extensions/common/manifest_constants.cc
index e0433b3b00e6ca2a7d6020df8a4c672b3f08dd60..01e4456bd4c4b276158d3782f6da2dc29c5d23f5 100644
--- a/extensions/common/manifest_constants.cc
+++ b/extensions/common/manifest_constants.cc
@@ -75,6 +75,7 @@ const char kLaunchWidth[] = "app.launch.width";
const char kLayouts[] = "layouts";
const char kManifestVersion[] = "manifest_version";
const char kMatches[] = "matches";
+const char kMatchesAboutBlank[] = "matches_about_blank";
not at google - send to devlin 2014/04/21 19:56:22 kMatchAboutBlank / match_about_blank
robwu 2014/04/21 22:15:41 Done.
const char kMinimumChromeVersion[] = "minimum_chrome_version";
const char kMinimumVersion[] = "minimum_version";
const char kMIMETypes[] = "mime_types";
@@ -477,6 +478,8 @@ const char kInvalidMatchCount[] =
"one match specified.";
const char kInvalidMatches[] =
"Required value 'content_scripts[*].matches' is missing or invalid.";
+const char kInvalidMatchesAboutBlank[] =
+ "Invalid value for 'content_scripts[*].matches_about_blank'.";
const char kInvalidMIMETypes[] =
"Invalid value for 'mime_types'";
const char kInvalidMimeTypesHandler[] =

Powered by Google App Engine
This is Rietveld 408576698