extensions/common/permissions/permissions_data.cc - Issue 226663003: Allow content script insertion on about:-URLs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/permissions/permissions_data.cc

Issue 226663003: Allow content script insertion on about:-URLs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use matches_about_blank key instead of about:* permission. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/permissions/permissions_data.cc

diff --git a/extensions/common/permissions/permissions_data.cc b/extensions/common/permissions/permissions_data.cc

index ca5d3ff6ff2b3aa6af2d8d1563728577715642a8..933e42a45988dd2ef76a73c592071707f9fa03cb 100644

--- a/extensions/common/permissions/permissions_data.cc

+++ b/extensions/common/permissions/permissions_data.cc

@@ -511,8 +511,8 @@ bool PermissionsData::CanExecuteScriptOnPage(const Extension* extension,

} else {

// Otherwise, see if this extension has permission to execute script

// programmatically on pages.

- can_access = GetActivePermissions(extension)->

- HasExplicitAccessToOrigin(document_url);

+ can_access =

+ GetActivePermissions(extension)->HasEffectiveAccessToURL(document_url);

}

if (!can_access && error) {