Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: extensions/common/manifest_constants.cc

Issue 226663003: Allow content script insertion on about:-URLs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use matches_about_blank key instead of about:* permission. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/common/manifest_constants.h" 5 #include "extensions/common/manifest_constants.h"
6 6
7 namespace extensions { 7 namespace extensions {
8 8
9 namespace manifest_keys { 9 namespace manifest_keys {
10 10
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 const char kLanguage[] = "language"; 68 const char kLanguage[] = "language";
69 const char kLaunch[] = "app.launch"; 69 const char kLaunch[] = "app.launch";
70 const char kLaunchContainer[] = "app.launch.container"; 70 const char kLaunchContainer[] = "app.launch.container";
71 const char kLaunchHeight[] = "app.launch.height"; 71 const char kLaunchHeight[] = "app.launch.height";
72 const char kLaunchLocalPath[] = "app.launch.local_path"; 72 const char kLaunchLocalPath[] = "app.launch.local_path";
73 const char kLaunchWebURL[] = "app.launch.web_url"; 73 const char kLaunchWebURL[] = "app.launch.web_url";
74 const char kLaunchWidth[] = "app.launch.width"; 74 const char kLaunchWidth[] = "app.launch.width";
75 const char kLayouts[] = "layouts"; 75 const char kLayouts[] = "layouts";
76 const char kManifestVersion[] = "manifest_version"; 76 const char kManifestVersion[] = "manifest_version";
77 const char kMatches[] = "matches"; 77 const char kMatches[] = "matches";
78 const char kMatchesAboutBlank[] = "matches_about_blank";
not at google - send to devlin 2014/04/21 19:56:22 kMatchAboutBlank / match_about_blank
robwu 2014/04/21 22:15:41 Done.
78 const char kMinimumChromeVersion[] = "minimum_chrome_version"; 79 const char kMinimumChromeVersion[] = "minimum_chrome_version";
79 const char kMinimumVersion[] = "minimum_version"; 80 const char kMinimumVersion[] = "minimum_version";
80 const char kMIMETypes[] = "mime_types"; 81 const char kMIMETypes[] = "mime_types";
81 const char kMimeTypesHandler[] = "mime_types_handler"; 82 const char kMimeTypesHandler[] = "mime_types_handler";
82 const char kName[] = "name"; 83 const char kName[] = "name";
83 const char kNaClModules[] = "nacl_modules"; 84 const char kNaClModules[] = "nacl_modules";
84 const char kNaClModulesMIMEType[] = "mime_type"; 85 const char kNaClModulesMIMEType[] = "mime_type";
85 const char kNaClModulesPath[] = "path"; 86 const char kNaClModulesPath[] = "path";
86 const char kOAuth2[] = "oauth2"; 87 const char kOAuth2[] = "oauth2";
87 const char kOAuth2AutoApprove[] = "oauth2.auto_approve"; 88 const char kOAuth2AutoApprove[] = "oauth2.auto_approve";
(...skipping 382 matching lines...) Expand 10 before | Expand all | Expand 10 after
470 const char kInvalidManifestVersionOld[] = 471 const char kInvalidManifestVersionOld[] =
471 "The 'manifest_version' key must be present and set to * (without quotes). " 472 "The 'manifest_version' key must be present and set to * (without quotes). "
472 "See developer.chrome.com/*/manifestVersion.html for details."; 473 "See developer.chrome.com/*/manifestVersion.html for details.";
473 const char kInvalidMatch[] = 474 const char kInvalidMatch[] =
474 "Invalid value for 'content_scripts[*].matches[*]': *"; 475 "Invalid value for 'content_scripts[*].matches[*]': *";
475 const char kInvalidMatchCount[] = 476 const char kInvalidMatchCount[] =
476 "Invalid value for 'content_scripts[*].matches'. There must be at least " 477 "Invalid value for 'content_scripts[*].matches'. There must be at least "
477 "one match specified."; 478 "one match specified.";
478 const char kInvalidMatches[] = 479 const char kInvalidMatches[] =
479 "Required value 'content_scripts[*].matches' is missing or invalid."; 480 "Required value 'content_scripts[*].matches' is missing or invalid.";
481 const char kInvalidMatchesAboutBlank[] =
482 "Invalid value for 'content_scripts[*].matches_about_blank'.";
480 const char kInvalidMIMETypes[] = 483 const char kInvalidMIMETypes[] =
481 "Invalid value for 'mime_types'"; 484 "Invalid value for 'mime_types'";
482 const char kInvalidMimeTypesHandler[] = 485 const char kInvalidMimeTypesHandler[] =
483 "Invalid value for 'mime_types'."; 486 "Invalid value for 'mime_types'.";
484 const char kInvalidMinimumChromeVersion[] = 487 const char kInvalidMinimumChromeVersion[] =
485 "Invalid value for 'minimum_chrome_version'."; 488 "Invalid value for 'minimum_chrome_version'.";
486 const char kInvalidName[] = 489 const char kInvalidName[] =
487 "Required value 'name' is missing or invalid."; 490 "Required value 'name' is missing or invalid.";
488 const char kInvalidNaClModules[] = 491 const char kInvalidNaClModules[] =
489 "Invalid value for 'nacl_modules'."; 492 "Invalid value for 'nacl_modules'.";
(...skipping 222 matching lines...) Expand 10 before | Expand all | Expand 10 after
712 const char kWebRequestConflictsWithLazyBackground[] = 715 const char kWebRequestConflictsWithLazyBackground[] =
713 "The 'webRequest' API cannot be used with event pages."; 716 "The 'webRequest' API cannot be used with event pages.";
714 #if defined(OS_CHROMEOS) 717 #if defined(OS_CHROMEOS)
715 const char kIllegalPlugins[] = 718 const char kIllegalPlugins[] =
716 "Extensions cannot install plugins on Chrome OS"; 719 "Extensions cannot install plugins on Chrome OS";
717 #endif 720 #endif
718 721
719 } // namespace manifest_errors 722 } // namespace manifest_errors
720 723
721 } // namespace extensions 724 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698