Issue 2266533002: Consistently use namespaced base::Version in components/update_client.

Issue 2266533002: Consistently use namespaced base::Version in components/update_client. (Closed)

Created:
4 years, 4 months ago by pwnall

Modified:
4 years, 4 months ago

Reviewers:
Sorin Jianu

CC:
chromium-reviews, waffles

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Consistently use namespaced base::Version in components/update_client. BUG=639416 Committed: https://crrev.com/db0b7241cb831c1a6cf66494bc0b611f6e80487a Cr-Commit-Position: refs/heads/master@{#413249}

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -32 lines)			Patch
M	components/update_client/action_update_check.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	components/update_client/crx_update_item.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	components/update_client/test_installer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	components/update_client/test_installer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	components/update_client/update_client.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	components/update_client/update_client.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	components/update_client/update_client_internal.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	components/update_client/update_client_unittest.cc	View	12 chunks	+18 lines, -18 lines	0 comments	Download
M	components/update_client/update_response.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 13 (7 generated)

pwnall

On 2016/08/19 20:31:51, Sorin Jianu wrote: > lgtm > > Thank you! Thank you for ...

4 years, 4 months ago (2016-08-19 20:32:31 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2266533002/1

4 years, 4 months ago (2016-08-19 21:32:36 UTC) #10

commit-bot: I haz the power

4 years, 4 months ago (2016-08-19 21:44:37 UTC) #13

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/db0b7241cb831c1a6cf66494bc0b611f6e80487a
Cr-Commit-Position: refs/heads/master@{#413249}