Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/update_client/update_client_unittest.cc

Issue 2266533002: Consistently use namespaced base::Version in components/update_client. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/update_client/update_client_internal.h ('k') | components/update_client/update_response.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/update_client/update_client_unittest.cc
diff --git a/components/update_client/update_client_unittest.cc b/components/update_client/update_client_unittest.cc
index 68e8dbe050de3c9ed665c5a4a81d0a638e44e917..a858783c92e9bd5e5dc94fd7f583ae9c14af35d4 100644
--- a/components/update_client/update_client_unittest.cc
+++ b/components/update_client/update_client_unittest.cc
@@ -210,7 +210,7 @@ TEST_F(UpdateClientTest, OneCrxNoUpdate) {
CrxComponent crx;
crx.name = "test_jebg";
crx.pk_hash.assign(jebg_hash, jebg_hash + arraysize(jebg_hash));
- crx.version = Version("0.9");
+ crx.version = base::Version("0.9");
crx.installer = new TestInstaller;
components->push_back(crx);
}
@@ -311,13 +311,13 @@ TEST_F(UpdateClientTest, TwoCrxUpdateNoUpdate) {
CrxComponent crx1;
crx1.name = "test_jebg";
crx1.pk_hash.assign(jebg_hash, jebg_hash + arraysize(jebg_hash));
- crx1.version = Version("0.9");
+ crx1.version = base::Version("0.9");
crx1.installer = new TestInstaller;
CrxComponent crx2;
crx2.name = "test_abag";
crx2.pk_hash.assign(abag_hash, abag_hash + arraysize(abag_hash));
- crx2.version = Version("2.2");
+ crx2.version = base::Version("2.2");
crx2.installer = new TestInstaller;
components->push_back(crx1);
@@ -498,13 +498,13 @@ TEST_F(UpdateClientTest, TwoCrxUpdate) {
CrxComponent crx1;
crx1.name = "test_jebg";
crx1.pk_hash.assign(jebg_hash, jebg_hash + arraysize(jebg_hash));
- crx1.version = Version("0.9");
+ crx1.version = base::Version("0.9");
crx1.installer = new TestInstaller;
CrxComponent crx2;
crx2.name = "test_ihfo";
crx2.pk_hash.assign(ihfo_hash, ihfo_hash + arraysize(ihfo_hash));
- crx2.version = Version("0.8");
+ crx2.version = base::Version("0.8");
crx2.installer = new TestInstaller;
components->push_back(crx1);
@@ -747,13 +747,13 @@ TEST_F(UpdateClientTest, TwoCrxUpdateDownloadTimeout) {
CrxComponent crx1;
crx1.name = "test_jebg";
crx1.pk_hash.assign(jebg_hash, jebg_hash + arraysize(jebg_hash));
- crx1.version = Version("0.9");
+ crx1.version = base::Version("0.9");
crx1.installer = new TestInstaller;
CrxComponent crx2;
crx2.name = "test_ihfo";
crx2.pk_hash.assign(ihfo_hash, ihfo_hash + arraysize(ihfo_hash));
- crx2.version = Version("0.8");
+ crx2.version = base::Version("0.8");
crx2.installer = new TestInstaller;
components->push_back(crx1);
@@ -1002,9 +1002,9 @@ TEST_F(UpdateClientTest, OneCrxDiffUpdate) {
crx.pk_hash.assign(ihfo_hash, ihfo_hash + arraysize(ihfo_hash));
crx.installer = installer;
if (num_calls == 1) {
- crx.version = Version("0.8");
+ crx.version = base::Version("0.8");
} else if (num_calls == 2) {
- crx.version = Version("1.0");
+ crx.version = base::Version("1.0");
} else {
NOTREACHED();
}
@@ -1300,7 +1300,7 @@ TEST_F(UpdateClientTest, OneCrxInstallError) {
CrxComponent crx;
crx.name = "test_jebg";
crx.pk_hash.assign(jebg_hash, jebg_hash + arraysize(jebg_hash));
- crx.version = Version("0.9");
+ crx.version = base::Version("0.9");
crx.installer = installer;
components->push_back(crx);
}
@@ -1480,9 +1480,9 @@ TEST_F(UpdateClientTest, OneCrxDiffUpdateFailsFullUpdateSucceeds) {
crx.pk_hash.assign(ihfo_hash, ihfo_hash + arraysize(ihfo_hash));
crx.installer = installer;
if (num_calls == 1) {
- crx.version = Version("0.8");
+ crx.version = base::Version("0.8");
} else if (num_calls == 2) {
- crx.version = Version("1.0");
+ crx.version = base::Version("1.0");
} else {
NOTREACHED();
}
@@ -1771,7 +1771,7 @@ TEST_F(UpdateClientTest, OneCrxNoUpdateQueuedCall) {
CrxComponent crx;
crx.name = "test_jebg";
crx.pk_hash.assign(jebg_hash, jebg_hash + arraysize(jebg_hash));
- crx.version = Version("0.9");
+ crx.version = base::Version("0.9");
crx.installer = new TestInstaller;
components->push_back(crx);
}
@@ -1876,7 +1876,7 @@ TEST_F(UpdateClientTest, OneCrxInstall) {
CrxComponent crx;
crx.name = "test_jebg";
crx.pk_hash.assign(jebg_hash, jebg_hash + arraysize(jebg_hash));
- crx.version = Version("0.0");
+ crx.version = base::Version("0.0");
crx.installer = new TestInstaller;
components->push_back(crx);
@@ -2053,7 +2053,7 @@ TEST_F(UpdateClientTest, ConcurrentInstallSameCRX) {
CrxComponent crx;
crx.name = "test_jebg";
crx.pk_hash.assign(jebg_hash, jebg_hash + arraysize(jebg_hash));
- crx.version = Version("0.0");
+ crx.version = base::Version("0.0");
crx.installer = new TestInstaller;
components->push_back(crx);
@@ -2286,7 +2286,7 @@ TEST_F(UpdateClientTest, RetryAfter) {
CrxComponent crx;
crx.name = "test_jebg";
crx.pk_hash.assign(jebg_hash, jebg_hash + arraysize(jebg_hash));
- crx.version = Version("0.9");
+ crx.version = base::Version("0.9");
crx.installer = new TestInstaller;
components->push_back(crx);
}
@@ -2462,14 +2462,14 @@ TEST_F(UpdateClientTest, TwoCrxUpdateOneUpdateDisabled) {
CrxComponent crx1;
crx1.name = "test_jebg";
crx1.pk_hash.assign(jebg_hash, jebg_hash + arraysize(jebg_hash));
- crx1.version = Version("0.9");
+ crx1.version = base::Version("0.9");
crx1.installer = new TestInstaller;
crx1.supports_group_policy_enable_component_updates = true;
CrxComponent crx2;
crx2.name = "test_ihfo";
crx2.pk_hash.assign(ihfo_hash, ihfo_hash + arraysize(ihfo_hash));
- crx2.version = Version("0.8");
+ crx2.version = base::Version("0.8");
crx2.installer = new TestInstaller;
components->push_back(crx1);
« no previous file with comments | « components/update_client/update_client_internal.h ('k') | components/update_client/update_response.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698