Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: components/update_client/action_update_check.cc

Issue 2266533002: Consistently use namespaced base::Version in components/update_client. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/update_client/crx_update_item.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/update_client/action_update_check.cc
diff --git a/components/update_client/action_update_check.cc b/components/update_client/action_update_check.cc
index 8d1cbdb27c369a885c8b985f4c3ab1666efd5b6f..ff625fb00a3e8d5841c5bddb671daf1bfbd38743 100644
--- a/components/update_client/action_update_check.cc
+++ b/components/update_client/action_update_check.cc
@@ -29,8 +29,8 @@ namespace update_client {
namespace {
// Returns true if the |proposed| version is newer than |current| version.
-bool IsVersionNewer(const Version& current, const std::string& proposed) {
- Version proposed_ver(proposed);
+bool IsVersionNewer(const base::Version& current, const std::string& proposed) {
+ base::Version proposed_ver(proposed);
return proposed_ver.IsValid() && current.CompareTo(proposed_ver) < 0;
}
@@ -70,7 +70,7 @@ void ActionUpdateCheck::Run(UpdateContext* update_context, Callback callback) {
item->crx_urls.clear();
item->crx_diffurls.clear();
item->previous_version = crx_component.version;
- item->next_version = Version();
+ item->next_version = base::Version();
item->previous_fp = crx_component.fingerprint;
item->next_fp.clear();
item->on_demand = update_context->is_foreground;
@@ -156,7 +156,7 @@ void ActionUpdateCheck::OnUpdateCheckSucceeded(
}
// Parse the members of the result and queue an upgrade for this CRX.
- crx->next_version = Version(it->manifest.version);
+ crx->next_version = base::Version(it->manifest.version);
VLOG(1) << "Update found for CRX: " << crx->id;
« no previous file with comments | « no previous file | components/update_client/crx_update_item.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698