Optimize posting of WTF::Closure and improve scheduler test mocks

Optimize posting of WTF::Closure and improve scheduler test mocks

Previously posting a WTF::Closure (which contains a
base::Closure) resulted in it getting wrapped in a WebTaskRunner::Task
which was then wrapped in a base::Closure!

We fix that here by posting the wrapped base::Closure directly.

We also and refactor the various blink scheduler mocks to use
either a real scheduler or a centralized FakeWebTaskRunner.

At Sami's request taskRunner has been renamed to
toSingleThreadTaskRunner.

BUG=638542
Committed: https://crrev.com/4dab46210f989c26fb3cb40064a8d60846015f38
Cr-Commit-Position: refs/heads/master@{#414834}

[alex clarke (OOO till 29th), 2016-08-19 14:56:52]

Description was changed from

==========
Introduce WebTaskRunner::postCancellableDelayedTask

We also optimize posting of a WTF::Closure and refactor the various
blink scheduler mocks to use either a real scheduler or a centralized
FakeWebTaskRunner.

BUG=605701, 605718, 638542
==========

to

==========
Introduce WebTaskRunner::postCancellableDelayedTask

We also optimize posting of a WTF::Closure and refactor the various
blink scheduler mocks to use either a real scheduler or a centralized
FakeWebTaskRunner.

Previously posting a WTF::Closure (which contains a
base::Closure) resulted in it getting wrapped in a WebTaskRunner::Task
which was then wrapped in a base::Closure!

BUG=605701, 605718, 638542
==========

[alex clarke (OOO till 29th), 2016-08-19 14:56:53]

alexclarke@chromium.org changed reviewers:
+ haraken@chromium.org, kinuko@chromium.org, skyostil@chromium.org

[alex clarke (OOO till 29th), 2016-08-19 14:57:02]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[alex clarke (OOO till 29th), 2016-08-19 14:57:11]

PTAL :)

[commit-bot: I haz the power, 2016-08-19 14:57:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alex clarke (OOO till 29th), 2016-08-19 16:39:16]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 16:39:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 21:33:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 21:33:32]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[haraken, 2016-08-22 05:28:48]

LGTM. This looks like a great simplification!

https://codereview.chromium.org/2266443002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h
(right):

https://codereview.chromium.org/2266443002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h:116: // This
function ignores future delayed tasks when deciding if the system, is idle.

system, => system

https://codereview.chromium.org/2266443002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h:122: void
runPendingTasks();

I'm just curious but when do we need this functionality?

[alex clarke (OOO till 29th), 2016-08-22 17:42:49]

alexclarke@chromium.org changed reviewers:
+ dcheng@chromium.org

[alex clarke (OOO till 29th), 2016-08-22 17:43:01]

https://codereview.chromium.org/2266443002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h
(right):

https://codereview.chromium.org/2266443002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h:116: // This
function ignores future delayed tasks when deciding if the system, is idle.
On 2016/08/22 05:28:48, haraken wrote:
> 
> system, => system

Done.

https://codereview.chromium.org/2266443002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h:122: void
runPendingTasks();
On 2016/08/22 05:28:48, haraken wrote:
> 
> I'm just curious but when do we need this functionality?

Looks like only one test in TimerTest.cpp was using it and runForPeriodSeconds()
worked there instead.  Lets drop it :)

https://codereview.chromium.org/2266443002/diff/20001/third_party/WebKit/publ...
File third_party/WebKit/public/platform/WebTaskRunner.h (right):

https://codereview.chromium.org/2266443002/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/platform/WebTaskRunner.h:52: virtual TaskHandle
postCancellableDelayedTask(const tracked_objects::Location&, const
base::Closure&, double delayMs) = 0;
Daniel on the other patch you expressed some API concerns. Are you OK with us
adding this? If further discussion is needed, I could split this off onto a
separate patch.

[alex clarke (OOO till 29th), 2016-08-22 20:31:06]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 20:32:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 22:51:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 22:51:10]

Dry run: This issue passed the CQ dry run.

[alex clarke (OOO till 29th), 2016-08-26 13:59:11]

Description was changed from

==========
Introduce WebTaskRunner::postCancellableDelayedTask

We also optimize posting of a WTF::Closure and refactor the various
blink scheduler mocks to use either a real scheduler or a centralized
FakeWebTaskRunner.

Previously posting a WTF::Closure (which contains a
base::Closure) resulted in it getting wrapped in a WebTaskRunner::Task
which was then wrapped in a base::Closure!

BUG=605701, 605718, 638542
==========

to

==========
Optimize posting of WTF::Closure and shceduler test mocks

Previously posting a WTF::Closure (which contains a
base::Closure) resulted in it getting wrapped in a WebTaskRunner::Task
which was then wrapped in a base::Closure!

We fix that here by posting the wrapped base::Closure directly.

We also and refactor the various
blink scheduler mocks to use either a real scheduler or a centralized
FakeWebTaskRunner.

BUG=638542
==========

[alex clarke (OOO till 29th), 2016-08-26 14:00:14]

Description was changed from

==========
Optimize posting of WTF::Closure and shceduler test mocks

Previously posting a WTF::Closure (which contains a
base::Closure) resulted in it getting wrapped in a WebTaskRunner::Task
which was then wrapped in a base::Closure!

We fix that here by posting the wrapped base::Closure directly.

We also and refactor the various
blink scheduler mocks to use either a real scheduler or a centralized
FakeWebTaskRunner.

BUG=638542
==========

to

==========
Optimize posting of WTF::Closure and shceduler test mocks

Previously posting a WTF::Closure (which contains a
base::Closure) resulted in it getting wrapped in a WebTaskRunner::Task
which was then wrapped in a base::Closure!

We fix that here by posting the wrapped base::Closure directly.

We also and refactor the various blink scheduler mocks to use 
either a real scheduler or a centralized FakeWebTaskRunner.

At Sami's request toTaskRunner has been renamed to 
toSingleThreadTaskRunner.

BUG=638542
==========

[alex clarke (OOO till 29th), 2016-08-26 14:00:37]

Description was changed from

==========
Optimize posting of WTF::Closure and shceduler test mocks

Previously posting a WTF::Closure (which contains a
base::Closure) resulted in it getting wrapped in a WebTaskRunner::Task
which was then wrapped in a base::Closure!

We fix that here by posting the wrapped base::Closure directly.

We also and refactor the various blink scheduler mocks to use 
either a real scheduler or a centralized FakeWebTaskRunner.

At Sami's request toTaskRunner has been renamed to 
toSingleThreadTaskRunner.

BUG=638542
==========

to

==========
Optimize posting of WTF::Closure and shceduler test mocks

Previously posting a WTF::Closure (which contains a
base::Closure) resulted in it getting wrapped in a WebTaskRunner::Task
which was then wrapped in a base::Closure!

We fix that here by posting the wrapped base::Closure directly.

We also and refactor the various blink scheduler mocks to use 
either a real scheduler or a centralized FakeWebTaskRunner.

At Sami's request taskRunner has been renamed to 
toSingleThreadTaskRunner.

BUG=638542
==========

[alex clarke (OOO till 29th), 2016-08-26 14:02:21]

Description was changed from

==========
Optimize posting of WTF::Closure and shceduler test mocks

Previously posting a WTF::Closure (which contains a
base::Closure) resulted in it getting wrapped in a WebTaskRunner::Task
which was then wrapped in a base::Closure!

We fix that here by posting the wrapped base::Closure directly.

We also and refactor the various blink scheduler mocks to use 
either a real scheduler or a centralized FakeWebTaskRunner.

At Sami's request taskRunner has been renamed to 
toSingleThreadTaskRunner.

BUG=638542
==========

to

==========
Optimize posting of WTF::Closure and scheduler test mocks

Previously posting a WTF::Closure (which contains a
base::Closure) resulted in it getting wrapped in a WebTaskRunner::Task
which was then wrapped in a base::Closure!

We fix that here by posting the wrapped base::Closure directly.

We also and refactor the various blink scheduler mocks to use 
either a real scheduler or a centralized FakeWebTaskRunner.

At Sami's request taskRunner has been renamed to 
toSingleThreadTaskRunner.

BUG=638542
==========

[alex clarke (OOO till 29th), 2016-08-26 14:03:47]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 14:04:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alex clarke (OOO till 29th), 2016-08-26 14:06:14]

alexclarke@chromium.org changed reviewers:
+ jochen@chromium.org

[alex clarke (OOO till 29th), 2016-08-26 14:06:15]

I removed the changes to introduce cancelable tasks on WebTaskRunner because
Daniel didn't want to introduce a new way of canceling tasks (it looks like we
can make WeakPtr cancellation just as fast).

What's left I believe is non-controversial and useful and I'd like to land that.

+ Jochen for an OWNERS review.

[Sami, 2016-08-26 14:40:59]

lgtm.

[haraken, 2016-08-26 14:46:21]

LGTM

[jochen (gone - plz use gerrit), 2016-08-26 15:00:45]

lgtm

[alex clarke (OOO till 29th), 2016-08-26 15:02:03]

The CQ bit was unchecked by alexclarke@chromium.org

[alex clarke (OOO till 29th), 2016-08-26 15:02:10]

The CQ bit was checked by alexclarke@chromium.org

[alex clarke (OOO till 29th), 2016-08-26 15:02:33]

Description was changed from

==========
Optimize posting of WTF::Closure and scheduler test mocks

Previously posting a WTF::Closure (which contains a
base::Closure) resulted in it getting wrapped in a WebTaskRunner::Task
which was then wrapped in a base::Closure!

We fix that here by posting the wrapped base::Closure directly.

We also and refactor the various blink scheduler mocks to use 
either a real scheduler or a centralized FakeWebTaskRunner.

At Sami's request taskRunner has been renamed to 
toSingleThreadTaskRunner.

BUG=638542
==========

to

==========
Optimize posting of WTF::Closure and improve scheduler test mocks

Previously posting a WTF::Closure (which contains a
base::Closure) resulted in it getting wrapped in a WebTaskRunner::Task
which was then wrapped in a base::Closure!

We fix that here by posting the wrapped base::Closure directly.

We also and refactor the various blink scheduler mocks to use 
either a real scheduler or a centralized FakeWebTaskRunner.

At Sami's request taskRunner has been renamed to 
toSingleThreadTaskRunner.

BUG=638542
==========

[commit-bot: I haz the power, 2016-08-26 15:02:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 17:26:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 17:26:52]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Sami, 2016-08-26 17:37:29]

The CQ bit was checked by skyostil@chromium.org

[commit-bot: I haz the power, 2016-08-26 17:37:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alex clarke (OOO till 29th), 2016-08-26 20:16:27]

The CQ bit was unchecked by alexclarke@chromium.org

[alex clarke (OOO till 29th), 2016-08-26 20:16:35]

The CQ bit was checked by alexclarke@chromium.org

[commit-bot: I haz the power, 2016-08-26 20:17:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 22:34:12]

Description was changed from

==========
Optimize posting of WTF::Closure and improve scheduler test mocks

Previously posting a WTF::Closure (which contains a
base::Closure) resulted in it getting wrapped in a WebTaskRunner::Task
which was then wrapped in a base::Closure!

We fix that here by posting the wrapped base::Closure directly.

We also and refactor the various blink scheduler mocks to use 
either a real scheduler or a centralized FakeWebTaskRunner.

At Sami's request taskRunner has been renamed to 
toSingleThreadTaskRunner.

BUG=638542
==========

to

==========
Optimize posting of WTF::Closure and improve scheduler test mocks

Previously posting a WTF::Closure (which contains a
base::Closure) resulted in it getting wrapped in a WebTaskRunner::Task
which was then wrapped in a base::Closure!

We fix that here by posting the wrapped base::Closure directly.

We also and refactor the various blink scheduler mocks to use 
either a real scheduler or a centralized FakeWebTaskRunner.

At Sami's request taskRunner has been renamed to 
toSingleThreadTaskRunner.

BUG=638542
==========

[commit-bot: I haz the power, 2016-08-26 22:34:13]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-26 22:36:12]

Description was changed from

==========
Optimize posting of WTF::Closure and improve scheduler test mocks

Previously posting a WTF::Closure (which contains a
base::Closure) resulted in it getting wrapped in a WebTaskRunner::Task
which was then wrapped in a base::Closure!

We fix that here by posting the wrapped base::Closure directly.

We also and refactor the various blink scheduler mocks to use 
either a real scheduler or a centralized FakeWebTaskRunner.

At Sami's request taskRunner has been renamed to 
toSingleThreadTaskRunner.

BUG=638542
==========

to

==========
Optimize posting of WTF::Closure and improve scheduler test mocks

Previously posting a WTF::Closure (which contains a
base::Closure) resulted in it getting wrapped in a WebTaskRunner::Task
which was then wrapped in a base::Closure!

We fix that here by posting the wrapped base::Closure directly.

We also and refactor the various blink scheduler mocks to use
either a real scheduler or a centralized FakeWebTaskRunner.

At Sami's request taskRunner has been renamed to
toSingleThreadTaskRunner.

BUG=638542

Committed: https://crrev.com/4dab46210f989c26fb3cb40064a8d60846015f38
Cr-Commit-Position: refs/heads/master@{#414834}
==========

[commit-bot: I haz the power, 2016-08-26 22:36:14]

Patchset 4 (id:??) landed as
https://crrev.com/4dab46210f989c26fb3cb40064a8d60846015f38
Cr-Commit-Position: refs/heads/master@{#414834}