Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp

Issue 2266443002: Optimize posting of WTF::Closure and improve scheduler test mocks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cut back to just the WTF::Closure fix plus the scheduler test mock refactor. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp
diff --git a/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp b/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp
index ea1834346dac8c0a50ca07cb69ee3934aaee2c1a..6c22c275962239c8acea93b4864d12be8f1b6e08 100644
--- a/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp
+++ b/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp
@@ -38,6 +38,7 @@
#include "platform/SharedBuffer.h"
#include "platform/exported/WrappedResourceResponse.h"
#include "platform/graphics/Image.h"
+#include "platform/scheduler/test/fake_web_task_runner.h"
#include "platform/testing/URLTestHelpers.h"
#include "platform/testing/UnitTestHelpers.h"
#include "public/platform/Platform.h"
@@ -152,16 +153,6 @@ void receiveResponse(ImageResource* imageResource, const KURL& url, const Atomic
imageResource->finish();
}
-class MockTaskRunner : public blink::WebTaskRunner {
- void postTask(const WebTraceLocation&, Task*) override { }
- void postDelayedTask(const WebTraceLocation&, Task*, double) override { }
- bool runsTasksOnCurrentThread() override { return true; }
- std::unique_ptr<WebTaskRunner> clone() override { return nullptr; }
- double virtualTimeSeconds() const override { return 0.0; }
- double monotonicallyIncreasingVirtualTimeSeconds() const override { return 0.0; }
- SingleThreadTaskRunner* taskRunner() override { return nullptr; }
-};
-
}
class ImageResourceTestMockFetchContext : public FetchContext {
@@ -180,10 +171,10 @@ public:
private:
ImageResourceTestMockFetchContext()
- : m_runner(wrapUnique(new MockTaskRunner))
+ : m_runner(wrapUnique(new scheduler::FakeWebTaskRunner))
{ }
- std::unique_ptr<MockTaskRunner> m_runner;
+ std::unique_ptr<scheduler::FakeWebTaskRunner> m_runner;
};
TEST(ImageResourceTest, MultipartImage)
« no previous file with comments | « third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp ('k') | third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698