Issue 226623007: Handlify TypeFeedbackOracle::SetInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 226623007: Handlify TypeFeedbackOracle::SetInfo. (Closed)

Created:
6 years, 8 months ago by Yang

Modified:
6 years, 8 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Handlify TypeFeedbackOracle::SetInfo. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20547

Patch Set 2 : addressed comment #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -7 lines)			Patch
	M	src/type-info.cc	View	1	1 chunk	+4 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yang

On 2014/04/07 11:51:49, Yang wrote: The DisallowHeapAllocation scope is mostly for documentation, since we already ...

6 years, 8 months ago (2014-04-07 11:52:37 UTC) #2

Michael Starzinger

LGTM. https://codereview.chromium.org/226623007/diff/1/src/type-info.cc File src/type-info.cc (left): https://codereview.chromium.org/226623007/diff/1/src/type-info.cc#oldcode499 src/type-info.cc:499: // Dictionary has been allocated with sufficient size ...

6 years, 8 months ago (2014-04-07 12:27:56 UTC) #3

Yang

6 years, 8 months ago (2014-04-07 12:55:11 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r20547 (presubmit successful).

Expand Messages | Collapse Messages

Issue 226623007: Handlify TypeFeedbackOracle::SetInfo. (Closed)

Description

Patch Set 1 #

Patch Set 2 : addressed comment #

Messages