Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Side by Side Diff: src/type-info.cc

Issue 226623007: Handlify TypeFeedbackOracle::SetInfo. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comment Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 474 matching lines...) Expand 10 before | Expand all | Expand 10 after
485 default: 485 default:
486 break; 486 break;
487 } 487 }
488 } 488 }
489 } 489 }
490 490
491 491
492 void TypeFeedbackOracle::SetInfo(TypeFeedbackId ast_id, Object* target) { 492 void TypeFeedbackOracle::SetInfo(TypeFeedbackId ast_id, Object* target) {
493 ASSERT(dictionary_->FindEntry(IdToKey(ast_id)) == 493 ASSERT(dictionary_->FindEntry(IdToKey(ast_id)) ==
494 UnseededNumberDictionary::kNotFound); 494 UnseededNumberDictionary::kNotFound);
495 MaybeObject* maybe_result = dictionary_->AtNumberPut(IdToKey(ast_id), target);
496 USE(maybe_result);
497 #ifdef DEBUG
498 Object* result = NULL;
499 // Dictionary has been allocated with sufficient size for all elements. 495 // Dictionary has been allocated with sufficient size for all elements.
500 ASSERT(maybe_result->ToObject(&result)); 496 DisallowHeapAllocation no_need_to_resize_dictionary;
501 ASSERT(*dictionary_ == result); 497 HandleScope scope(isolate());
502 #endif 498 isolate()->factory()->DictionaryAtNumberPut(
499 dictionary_, IdToKey(ast_id), handle(target, isolate()));
503 } 500 }
504 501
505 502
506 } } // namespace v8::internal 503 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698