Handlify TypeFeedbackOracle::SetInfo.

src/type-info.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 474 matching lines @@
       default:
         break;
     }
   }
 }
 
 
 void TypeFeedbackOracle::SetInfo(TypeFeedbackId ast_id, Object* target) {
   ASSERT(dictionary_->FindEntry(IdToKey(ast_id)) ==
          UnseededNumberDictionary::kNotFound);
-  MaybeObject* maybe_result = dictionary_->AtNumberPut(IdToKey(ast_id), target);
-  USE(maybe_result);
-#ifdef DEBUG
-  Object* result = NULL;
-  // Dictionary has been allocated with sufficient size for all elements.

[Michael Starzinger, 2014/04/07 12:27:56]

nit: Can we preserve this comment above the DisallowHeapAllocation scope.

-  ASSERT(maybe_result->ToObject(&result));
-  ASSERT(*dictionary_ == result);
-#endif
+  DisallowHeapAllocation no_need_to_resize_dictionary;
+  HandleScope scope(isolate());
+  isolate()->factory()->DictionaryAtNumberPut(
+      dictionary_, IdToKey(ast_id), Handle<Object>(target, isolate()));

[Michael Starzinger, 2014/04/07 12:27:56]

nit: Using "handle(target, isolate())" is shorter.

 }
 
 
 } }  // namespace v8::internal