Fix an overflow in valueAsDate setter of temporal input types.

Fix an overflow in valueAsDate setter of temporal input types.

According to the HTML specification [1], we should throw a TypeError if a non-Date
object is specified to valueAsDate.
 - Update toCoreDate() so that it throws a TypeError for non-Date objects.
 - Also, add DCHECKs to WTF::msToYear.

Note: Web IDL CR doesn't accept |null| for Date conversion [2]. However the
specification itself is deprecated.

[1] https://html.spec.whatwg.org/multipage/forms.html#dom-input-valueasdate
[2] https://www.w3.org/TR/WebIDL/#es-Date

BUG=637115
Committed: https://crrev.com/338614224cc310e73e59496869000ef87b46e6c1
Cr-Commit-Position: refs/heads/master@{#413410}

[tkent, 2016-08-19 08:20:11]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 08:20:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-08-19 08:35:34]

Description was changed from

==========
t# Enter a description of the change.
Fix an overflow in valueAsDate setting of month input type.

WTF::msToYear can't handle arbitrary double values.
 - Check millisecond value range in BaseTemporalInputType.
 - Also, add DCHECKs to WTF::msToYear.

BUG=637115
==========

to

==========
Fix an overflow in valueAsDate setter of month input type.

WTF::msToYear can't handle arbitrary double values.
 - Check millisecond value range in BaseTemporalInputType.
 - Also, add DCHECKs to WTF::msToYear.

BUG=637115
==========

[commit-bot: I haz the power, 2016-08-19 12:29:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 12:29:55]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[tkent, 2016-08-22 01:52:06]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 01:52:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-08-22 01:54:53]

Description was changed from

==========
Fix an overflow in valueAsDate setter of month input type.

WTF::msToYear can't handle arbitrary double values.
 - Check millisecond value range in BaseTemporalInputType.
 - Also, add DCHECKs to WTF::msToYear.

BUG=637115
==========

to

==========
Fix an overflow in valueAsDate setter of temporal input types.

According to the WebIDL specification [1], we should throw a TypeError if a
non-Date
object is specified to valueAsDate.
 - Update toCoreDate() so that it throws a TypeError for non-Date objects.
 - Also, add DCHECKs to WTF::msToYear.

[1] https://www.w3.org/TR/WebIDL/#es-Date

BUG=637115
==========

[tkent, 2016-08-22 01:55:02]

Patchset #1 (id:1) has been deleted

[tkent, 2016-08-22 02:45:14]

tkent@chromium.org changed reviewers:
+ bashi@chromium.org

[tkent, 2016-08-22 02:45:14]

bashi@, would you review this please?

[bashi, 2016-08-22 03:13:59]

Changes itself lgtm.

Could you update the description to reflect followings?

- We don't follow the old spec you mentioned in the description.
- Instead, we uses the latest draft [1] and Date object was removed from the
draft [2].
- According to [3], throwing a TypeError is the correct behavior.

[1] http://heycam.github.io/webidl/
[2] https://www.w3.org/Bugs/Public/show_bug.cgi?id=22824
[3] https://html.spec.whatwg.org/multipage/forms.html#dom-input-valueasdate

[tkent, 2016-08-22 03:23:12]

On 2016/08/22 at 03:13:59, bashi wrote:
> Changes itself lgtm.
> 
> Could you update the description to reflect followings?
> 
> - We don't follow the old spec you mentioned in the description.
> - Instead, we uses the latest draft [1] and Date object was removed from the
draft [2].
> - According to [3], throwing a TypeError is the correct behavior.
> 
> [1] http://heycam.github.io/webidl/
> [2] https://www.w3.org/Bugs/Public/show_bug.cgi?id=22824
> [3] https://html.spec.whatwg.org/multipage/forms.html#dom-input-valueasdate

Wow, I didn't know the WebIDL spec I referred was obsoleted.
According to [3], |null| should be accepted and Patch Set 1 is incorrect.  I'll
update this CL.

[tkent, 2016-08-22 03:46:01]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 03:46:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-08-22 05:21:36]

Description was changed from

==========
Fix an overflow in valueAsDate setter of temporal input types.

According to the WebIDL specification [1], we should throw a TypeError if a
non-Date
object is specified to valueAsDate.
 - Update toCoreDate() so that it throws a TypeError for non-Date objects.
 - Also, add DCHECKs to WTF::msToYear.

[1] https://www.w3.org/TR/WebIDL/#es-Date

BUG=637115
==========

to

==========
Fix an overflow in valueAsDate setter of temporal input types.

According to the HTML specification [1], we should throw a TypeError if a
non-Date
object is specified to valueAsDate.
 - Update toCoreDate() so that it throws a TypeError for non-Date objects.
 - Also, add DCHECKs to WTF::msToYear.

Note: Web IDL CR doesn't accept |null| for Date conversion [2]. However it's
deprecated.

[1] https://html.spec.whatwg.org/multipage/forms.html#dom-input-valueasdate
[2] https://www.w3.org/TR/WebIDL/#es-Date

BUG=637115
==========

[tkent, 2016-08-22 05:22:30]

Uploaded a new patch set.  Please take another look at it.

[bashi, 2016-08-22 05:30:48]

still lgtm.

[tkent, 2016-08-22 05:35:18]

Description was changed from

==========
Fix an overflow in valueAsDate setter of temporal input types.

According to the HTML specification [1], we should throw a TypeError if a
non-Date
object is specified to valueAsDate.
 - Update toCoreDate() so that it throws a TypeError for non-Date objects.
 - Also, add DCHECKs to WTF::msToYear.

Note: Web IDL CR doesn't accept |null| for Date conversion [2]. However it's
deprecated.

[1] https://html.spec.whatwg.org/multipage/forms.html#dom-input-valueasdate
[2] https://www.w3.org/TR/WebIDL/#es-Date

BUG=637115
==========

to

==========
Fix an overflow in valueAsDate setter of temporal input types.

According to the HTML specification [1], we should throw a TypeError if a
non-Date
object is specified to valueAsDate.
 - Update toCoreDate() so that it throws a TypeError for non-Date objects.
 - Also, add DCHECKs to WTF::msToYear.

Note: Web IDL CR doesn't accept |null| for Date conversion [2]. However the
specification itself is deprecated.

[1] https://html.spec.whatwg.org/multipage/forms.html#dom-input-valueasdate
[2] https://www.w3.org/TR/WebIDL/#es-Date

BUG=637115
==========

[commit-bot: I haz the power, 2016-08-22 05:42:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 05:42:15]

Dry run: This issue passed the CQ dry run.

[tkent, 2016-08-22 05:42:56]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-08-22 05:43:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 05:47:23]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-08-22 05:48:46]

Description was changed from

==========
Fix an overflow in valueAsDate setter of temporal input types.

According to the HTML specification [1], we should throw a TypeError if a
non-Date
object is specified to valueAsDate.
 - Update toCoreDate() so that it throws a TypeError for non-Date objects.
 - Also, add DCHECKs to WTF::msToYear.

Note: Web IDL CR doesn't accept |null| for Date conversion [2]. However the
specification itself is deprecated.

[1] https://html.spec.whatwg.org/multipage/forms.html#dom-input-valueasdate
[2] https://www.w3.org/TR/WebIDL/#es-Date

BUG=637115
==========

to

==========
Fix an overflow in valueAsDate setter of temporal input types.

According to the HTML specification [1], we should throw a TypeError if a
non-Date
object is specified to valueAsDate.
 - Update toCoreDate() so that it throws a TypeError for non-Date objects.
 - Also, add DCHECKs to WTF::msToYear.

Note: Web IDL CR doesn't accept |null| for Date conversion [2]. However the
specification itself is deprecated.

[1] https://html.spec.whatwg.org/multipage/forms.html#dom-input-valueasdate
[2] https://www.w3.org/TR/WebIDL/#es-Date

BUG=637115

Committed: https://crrev.com/338614224cc310e73e59496869000ef87b46e6c1
Cr-Commit-Position: refs/heads/master@{#413410}
==========

[commit-bot: I haz the power, 2016-08-22 05:48:48]

Patchset 2 (id:??) landed as
https://crrev.com/338614224cc310e73e59496869000ef87b46e6c1
Cr-Commit-Position: refs/heads/master@{#413410}