third_party/WebKit/Source/bindings/scripts/v8_types.py - Issue 2265443002: Fix an overflow in valueAsDate setter of temporal input types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_types.py

Issue 2265443002: Fix an overflow in valueAsDate setter of temporal input types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: accept null Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8Binding.h ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/scripts/v8_types.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_types.py b/third_party/WebKit/Source/bindings/scripts/v8_types.py

index 87d6ef20a9fa11c86a90c7259505d9f72300f803..1fe8b5aced561215d284a302b4bec9f7b16c107f 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_types.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_types.py

@@ -472,7 +472,7 @@ def set_component_dirs(new_component_dirs):

V8_VALUE_TO_CPP_VALUE = {

# Basic

- 'Date': 'toCoreDate({isolate}, {v8_value})',

+ 'Date': 'toCoreDate({isolate}, {v8_value}, exceptionState)',

'DOMString': '{v8_value}',

'ByteString': 'toByteString({isolate}, {arguments})',

'USVString': 'toUSVString({isolate}, {arguments})',

@@ -506,7 +506,7 @@ def v8_conversion_needs_exception_state(idl_type):

return (idl_type.is_numeric_type or

idl_type.is_enum or

idl_type.is_dictionary or

- idl_type.name in ('Boolean', 'ByteString', 'Dictionary', 'USVString', 'SerializedScriptValue'))

+ idl_type.name in ('Boolean', 'ByteString', 'Date', 'Dictionary', 'USVString', 'SerializedScriptValue'))

IdlType.v8_conversion_needs_exception_state = property(v8_conversion_needs_exception_state)

IdlArrayOrSequenceType.v8_conversion_needs_exception_state = True