Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: third_party/WebKit/LayoutTests/fast/forms/time/time-valueasdate.html

Issue 2265443002: Fix an overflow in valueAsDate setter of temporal input types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: accept null Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <html> 2 <html>
3 <head> 3 <head>
4 <script src="../../../resources/js-test.js"></script> 4 <script src="../../../resources/js-test.js"></script>
5 </head> 5 </head>
6 <body> 6 <body>
7 <p id="description"></p> 7 <p id="description"></p>
8 <div id="console"></div> 8 <div id="console"></div>
9 <script> 9 <script>
10 description('Tests for .valueAsDate with &lt;input type=time>.'); 10 description('Tests for .valueAsDate with &lt;input type=time>.');
(...skipping 25 matching lines...) Expand all
36 shouldBe('setValueAsDateAndGetValue(12, 0, 0, 0)', '"12:00"'); 36 shouldBe('setValueAsDateAndGetValue(12, 0, 0, 0)', '"12:00"');
37 shouldBe('setValueAsDateAndGetValue(23, 59, 59, 999)', '"23:59:59.999"'); 37 shouldBe('setValueAsDateAndGetValue(23, 59, 59, 999)', '"23:59:59.999"');
38 shouldBe('setValueAsDateAndGetValue(24, 0, 0, 0)', '"00:00"'); 38 shouldBe('setValueAsDateAndGetValue(24, 0, 0, 0)', '"00:00"');
39 shouldBe('setValueAsDateAndGetValue(48, 0, 13, 0)', '"00:00:13"'); 39 shouldBe('setValueAsDateAndGetValue(48, 0, 13, 0)', '"00:00:13"');
40 shouldBe('setValueAsDateAndGetValue(-23, -59, -59, 0)', '"00:00:01"'); 40 shouldBe('setValueAsDateAndGetValue(-23, -59, -59, 0)', '"00:00:01"');
41 41
42 debug('Invalid Date:'); 42 debug('Invalid Date:');
43 // Date of JavaScript can't represent 8.65E15. 43 // Date of JavaScript can't represent 8.65E15.
44 shouldBe('var date = new Date(); date.setTime(8.65E15); input.valueAsDate = date ; input.value', '""'); 44 shouldBe('var date = new Date(); date.setTime(8.65E15); input.valueAsDate = date ; input.value', '""');
45 debug('Invalid objects:'); 45 debug('Invalid objects:');
46 shouldBe('input.value = "00:00"; input.valueAsDate = document; input.value', '"" '); 46 shouldThrow('input.valueAsDate = document');
47 shouldBe('input.value = "00:00"; input.valueAsDate = null; input.value', '""'); 47 shouldBe('input.value = "00:00"; input.valueAsDate = null; input.value', '""');
48 48
49 debug('Step attribute value and string representation:'); 49 debug('Step attribute value and string representation:');
50 // If the step attribute value is 1 second and the second part is 0, we should s how the second part. 50 // If the step attribute value is 1 second and the second part is 0, we should s how the second part.
51 shouldBe('input.step = "1"; setValueAsDateAndGetValue(0, 0, 0, 0)', '"00:00:00"' ); 51 shouldBe('input.step = "1"; setValueAsDateAndGetValue(0, 0, 0, 0)', '"00:00:00"' );
52 // If the step attribute value is 0.001 second and the millisecond part is 0, we should show the millisecond part. 52 // If the step attribute value is 0.001 second and the millisecond part is 0, we should show the millisecond part.
53 shouldBe('input.step = "0.001"; setValueAsDateAndGetValue(0, 0, 0, 0)', '"00:00: 00.000"'); 53 shouldBe('input.step = "0.001"; setValueAsDateAndGetValue(0, 0, 0, 0)', '"00:00: 00.000"');
54 </script> 54 </script>
55 </body> 55 </body>
56 </html> 56 </html>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698