chrome/browser/resources/settings/settings_shared_css.html - Issue 2265253002: Replace Manage Languages with dialog and dropdown item

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_shared_css.html

Issue 2265253002: Replace Manage Languages with dialog and dropdown item (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@EnableDisableLanguage

Patch Set: remove unused prefs object Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/languages_page/languages_page.js ('K') | « chrome/browser/resources/settings/settings_resources.grd ('k') | chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc » ('j') | chrome/test/data/webui/settings/languages_page_browsertest.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/settings_shared_css.html

diff --git a/chrome/browser/resources/settings/settings_shared_css.html b/chrome/browser/resources/settings/settings_shared_css.html

index 23f29ad0021e290d56eb2f2a99957db1eac27484..97c29a6d72ba9574152099c2843b2464bae9c985 100644

--- a/chrome/browser/resources/settings/settings_shared_css.html

+++ b/chrome/browser/resources/settings/settings_shared_css.html

@@ -75,11 +75,15 @@

box-shadow: 0 2px 6px var(--paper-grey-500);

}

- iron-dropdown .dropdown-content .dropdown-item,

+ iron-dropdown .dropdown-content .dropdown-item:not([disabled]),

iron-dropdown .dropdown-content paper-item {

@apply(--settings-actionable);

}

+ iron-dropdown .dropdown-content .dropdown-item[disabled] {

+ opacity: .65;

+ }

span ~ a {

-webkit-margin-start: 4px;

}

@@ -225,7 +229,7 @@

}

.list-item > label span[disabled] {

- opacity: .65; /* TODO(michaelpg): check this value with bettes. */

+ opacity: .65;

stevenjb 2016/08/23 17:08:04 We should define .65 in settings_vars_css.html and

michaelpg 2016/08/23 23:37:06 Done.

}

.list-item > paper-icon-item {