chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc - Issue 2265253002: Replace Manage Languages with dialog and dropdown item

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Issue 2265253002: Replace Manage Languages with dialog and dropdown item (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@EnableDisableLanguage

Patch Set: remove unused prefs object Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/settings_shared_css.html ('K') | « chrome/browser/resources/settings/settings_shared_css.html ('k') | chrome/test/data/webui/settings/languages_page_browsertest.js » ('j') | chrome/test/data/webui/settings/languages_page_browsertest.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

diff --git a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

index 7dbcf833762403ab361a2d093064227a0eb3cbf7..5b8431614340ec73e5b129d2a47198e57b29d339 100644

--- a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

+++ b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

@@ -694,9 +694,10 @@ void AddLanguagesStrings(content::WebUIDataSource* html_source) {

IDS_SETTINGS_LANGUAGES_LANGUAGES_LIST_ORDERING_INSTRUCTIONS},

{"moveUp", IDS_SETTINGS_LANGUAGES_LANGUAGES_LIST_MOVE_UP},

{"moveDown", IDS_SETTINGS_LANGUAGES_LANGUAGES_LIST_MOVE_DOWN},

+ {"removeLanguage", IDS_SETTINGS_LANGUAGES_LANGUAGES_LIST_REMOVE},

{"languageDetail",

IDS_SETTINGS_LANGUAGES_LANGUAGES_LIST_LANGUAGE_DETAIL},

- {"manageLanguages", IDS_SETTINGS_LANGUAGES_LANGUAGES_MANAGE},

+ {"addLanguages", IDS_SETTINGS_LANGUAGES_LANGUAGES_ADD},

#if defined(OS_CHROMEOS)

{"inputMethodsListTitle",

IDS_SETTINGS_LANGUAGES_INPUT_METHODS_LIST_TITLE},

@@ -704,7 +705,7 @@ void AddLanguagesStrings(content::WebUIDataSource* html_source) {

{"manageInputMethodsPageTitle",

IDS_SETTINGS_LANGUAGES_MANAGE_INPUT_METHODS_TITLE},

#endif

- {"manageLanguagesPageTitle",

+ {"addLanguagesDialogTitle",

IDS_SETTINGS_LANGUAGES_MANAGE_LANGUAGES_TITLE},

{"allLanguages", IDS_SETTINGS_LANGUAGES_ALL_LANGUAGES},

{"enabledLanguages", IDS_SETTINGS_LANGUAGES_ENABLED_LANGUAGES},