Chromium Code Reviews| Index: chrome/browser/resources/settings/languages_page/languages_page.js |
| diff --git a/chrome/browser/resources/settings/languages_page/languages_page.js b/chrome/browser/resources/settings/languages_page/languages_page.js |
| index c16e69770ad4df9448550b0e0e94628859a68032..5168f03669f61214e91bf9cc520c1c286002332c 100644 |
| --- a/chrome/browser/resources/settings/languages_page/languages_page.js |
| +++ b/chrome/browser/resources/settings/languages_page/languages_page.js |
| @@ -46,6 +46,9 @@ Polymer({ |
| * @private |
| */ |
| detailLanguage_: Object, |
| + |
| + /** @private */ |
| + showAddLanguagesDialog_: Boolean, |
| }, |
| /** |
| @@ -89,12 +92,18 @@ Polymer({ |
| }, |
| /** |
| - * Opens the Manage Languages page. |
| + * Stamps and opens the Add Languages dialog, registering a listener to |
| + * disable the dialog's dom-if again on close. |
| * @private |
| */ |
| - onManageLanguagesTap_: function() { |
| - settings.navigateTo(settings.Route.MANAGE_LANGUAGES); |
| - this.forceRenderList_('settings-manage-languages-page'); |
| + onAddLanguagesTap_: function() { |
| + this.showAddLanguagesDialog_ = true; |
| + this.async(function() { |
| + var dialog = this.$$('settings-add-languages-dialog'); |
| + dialog.addEventListener('close', function() { |
| + this.showAddLanguagesDialog_ = false; |
| + }.bind(this)); |
|
stevenjb
2016/08/23 17:08:04
Don't we need to call show() or showModal() on the
michaelpg
2016/08/23 23:37:06
attached() does that (so we don't have to do it as
|
| + }); |
| }, |
| /** |
| @@ -146,6 +155,15 @@ Polymer({ |
| }, |
| /** |
| + * Disables the language. |
| + * @param {!{model: !{item: !LanguageState}}} e |
| + * @private |
| + */ |
| + onRemoveLanguageTap_: function(e) { |
| + this.languageHelper.disableLanguage(e.model.item.language.code); |
| + }, |
| + |
| + /** |
| * Opens the Language Detail page for the language. |
| * @param {!{model: !{item: !LanguageState}}} e |
| * @private |