MD History: Lazily load element files which are not needed for first paint

MD History: Lazily load element files which are not needed for first paint

This splits out many invisible or heavy elements into a separate
lazy_load.html file, which is only imported after the main app has
rendered. Where necessary, simple CSS shims are added to prevent visible
changes to the page.

In effect, this splits apart the first meaningful paint from the page
being fully interactive, and in the process improves first meaningful
paint by 10-15%.

BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/cf585f19edbbbfcfabd421a057e68a1d4cee860f
Cr-Commit-Position: refs/heads/master@{#420550}

[tsergeant, 2016-08-22 07:32:19]

Description was changed from

==========
MD History: Lazily load element files which are not needed for first paint

This splits out many invisible or heavy elements into a separate
lazy_load.html file, which is only imported after the main app has
rendered. Where necessary, simple CSS shims are added to prevent visible
changes to the page.

In effect, this splits apart the first meaningful paint from the page
being interactive, and in the process improves first meaningful paint by
10-15%.

BUG=629710
==========

to

==========
MD History: Lazily load element files which are not needed for first paint

This splits out many invisible or heavy elements into a separate
lazy_load.html file, which is only imported after the main app has
rendered. Where necessary, simple CSS shims are added to prevent visible
changes to the page.

In effect, this splits apart the first meaningful paint from the page
being interactive, and in the process improves first meaningful paint by
10-15%.

BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-08-22 07:36:23]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 07:36:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 07:43:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 07:43:12]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tsergeant, 2016-09-20 06:56:34]

Description was changed from

==========
MD History: Lazily load element files which are not needed for first paint

This splits out many invisible or heavy elements into a separate
lazy_load.html file, which is only imported after the main app has
rendered. Where necessary, simple CSS shims are added to prevent visible
changes to the page.

In effect, this splits apart the first meaningful paint from the page
being interactive, and in the process improves first meaningful paint by
10-15%.

BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: Lazily load element files which are not needed for first paint

This splits out many invisible or heavy elements into a separate
lazy_load.html file, which is only imported after the main app has
rendered. Where necessary, simple CSS shims are added to prevent visible
changes to the page.

In effect, this splits apart the first meaningful paint from the page
being fully interactive, and in the process improves first meaningful
paint by 10-15%.

BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-09-20 07:55:04]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 07:55:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 08:45:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 08:45:07]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2016-09-21 04:41:26]

Patchset #4 (id:60001) has been deleted

[tsergeant, 2016-09-21 04:42:01]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 04:42:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2016-09-21 05:22:38]

Patchset #4 (id:80001) has been deleted

[tsergeant, 2016-09-21 05:25:59]

tsergeant@chromium.org changed reviewers:
+ calamity@chromium.org

[tsergeant, 2016-09-21 05:26:00]

😪🎨

[calamity, 2016-09-22 04:00:10]

lgtm.

https://codereview.chromium.org/2264983002/diff/100001/chrome/browser/PRESUBM...
File chrome/browser/PRESUBMIT.py (right):

https://codereview.chromium.org/2264983002/diff/100001/chrome/browser/PRESUBM...
chrome/browser/PRESUBMIT.py:69: return (maybe_resource.LocalPath() not in
BLACKLIST and
May just want to filter all *.vulcanized.html and *.crisper.js here.

https://codereview.chromium.org/2264983002/diff/100001/chrome/browser/resourc...
File chrome/browser/resources/md_history/lazy_load.html (right):

https://codereview.chromium.org/2264983002/diff/100001/chrome/browser/resourc...
chrome/browser/resources/md_history/lazy_load.html:11: <link rel="import"
href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button-light.html">
Does the order of these matter? If so, put a comment at the top explaining, if
not, sort.

https://codereview.chromium.org/2264983002/diff/100001/chrome/browser/resourc...
File chrome/browser/resources/vulcanize.py (right):

https://codereview.chromium.org/2264983002/diff/100001/chrome/browser/resourc...
chrome/browser/resources/vulcanize.py:118: # imported by
lazy_load.vulcanized.html.
This seems to just do this silently. Any way to warn if lazy-loading of an
element gets broken by someone adding an import to the critical path?

[tsergeant, 2016-09-22 04:26:29]

Patchset #6 (id:140001) has been deleted

[tsergeant, 2016-09-22 04:27:57]

tsergeant@chromium.org changed reviewers:
+ dbeam@chromium.org, sgurun@chromium.org

[tsergeant, 2016-09-22 04:27:58]

Thanks!

+dbeam for WebUI,

+sgurun for tools/copyright_scanner/third_party_files_whitelist.txt

https://codereview.chromium.org/2264983002/diff/100001/chrome/browser/PRESUBM...
File chrome/browser/PRESUBMIT.py (right):

https://codereview.chromium.org/2264983002/diff/100001/chrome/browser/PRESUBM...
chrome/browser/PRESUBMIT.py:69: return (maybe_resource.LocalPath() not in
BLACKLIST and
On 2016/09/22 04:00:09, calamity wrote:
> May just want to filter all *.vulcanized.html and *.crisper.js here.

Done.

https://codereview.chromium.org/2264983002/diff/100001/chrome/browser/resourc...
File chrome/browser/resources/md_history/lazy_load.html (right):

https://codereview.chromium.org/2264983002/diff/100001/chrome/browser/resourc...
chrome/browser/resources/md_history/lazy_load.html:11: <link rel="import"
href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button-light.html">
On 2016/09/22 04:00:10, calamity wrote:
> Does the order of these matter? If so, put a comment at the top explaining, if
> not, sort.

Sorted

https://codereview.chromium.org/2264983002/diff/100001/chrome/browser/resourc...
File chrome/browser/resources/vulcanize.py (right):

https://codereview.chromium.org/2264983002/diff/100001/chrome/browser/resourc...
chrome/browser/resources/vulcanize.py:118: # imported by
lazy_load.vulcanized.html.
On 2016/09/22 04:00:10, calamity wrote:
> This seems to just do this silently. Any way to warn if lazy-loading of an
> element gets broken by someone adding an import to the critical path?

For the moment, this will have to be enforced by code review. It should be
pretty obvious if, say, paper-button moves from one vulcanized bundle to the
other just by eyeballing the files.

We could consider writing a script to figure out what elements are in each
bundle and reporting changes, but that's not a high priority right now.

[Dan Beam, 2016-09-22 04:42:06]

lgtm w/question

i'm trying to kill flattenhtml="true"

https://codereview.chromium.org/2264983002/diff/160001/chrome/browser/browser...
File chrome/browser/browser_resources.grd (right):

https://codereview.chromium.org/2264983002/diff/160001/chrome/browser/browser...
chrome/browser/browser_resources.grd:242: <include
name="IDR_MD_HISTORY_LAZY_LOAD_VULCANIZED_HTML"
file="resources\md_history\lazy_load.vulcanized.html" flattenhtml="true"
allowexternalscript="true" type="BINDATA" />
why do you need flattenhtml="true"?

[sgurun-gerrit only, 2016-09-23 00:20:01]

On 2016/09/22 04:42:06, Dan Beam wrote:
> lgtm w/question
> 
> i'm trying to kill flattenhtml="true"
> 
>
https://codereview.chromium.org/2264983002/diff/160001/chrome/browser/browser...
> File chrome/browser/browser_resources.grd (right):
> 
>
https://codereview.chromium.org/2264983002/diff/160001/chrome/browser/browser...
> chrome/browser/browser_resources.grd:242: <include
> name="IDR_MD_HISTORY_LAZY_LOAD_VULCANIZED_HTML"
> file="resources\md_history\lazy_load.vulcanized.html" flattenhtml="true"
> allowexternalscript="true" type="BINDATA" />
> why do you need flattenhtml="true"?

copyright_scanner lgtm

[tsergeant, 2016-09-23 01:19:51]

https://codereview.chromium.org/2264983002/diff/160001/chrome/browser/browser...
File chrome/browser/browser_resources.grd (right):

https://codereview.chromium.org/2264983002/diff/160001/chrome/browser/browser...
chrome/browser/browser_resources.grd:242: <include
name="IDR_MD_HISTORY_LAZY_LOAD_VULCANIZED_HTML"
file="resources\md_history\lazy_load.vulcanized.html" flattenhtml="true"
allowexternalscript="true" type="BINDATA" />
On 2016/09/22 04:42:06, Dan Beam wrote:
> why do you need flattenhtml="true"?

Hmmm, no reason. I've removed it from all the new things.

[tsergeant, 2016-09-23 01:35:42]

Alright, thanks for the reviews. Lets see what breaks.

(Hint: it's any local branch which touches a vulcanized file)

[tsergeant, 2016-09-23 01:35:50]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2016-09-23 01:35:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
calamity@chromium.org, sgurun@chromium.org, dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2264983002/#ps180001
(title: "Remove flattenhtml, rebase")

[commit-bot: I haz the power, 2016-09-23 01:36:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 02:36:07]

Committed patchset #7 (id:180001)

[commit-bot: I haz the power, 2016-09-23 02:38:11]

Description was changed from

==========
MD History: Lazily load element files which are not needed for first paint

This splits out many invisible or heavy elements into a separate
lazy_load.html file, which is only imported after the main app has
rendered. Where necessary, simple CSS shims are added to prevent visible
changes to the page.

In effect, this splits apart the first meaningful paint from the page
being fully interactive, and in the process improves first meaningful
paint by 10-15%.

BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: Lazily load element files which are not needed for first paint

This splits out many invisible or heavy elements into a separate
lazy_load.html file, which is only imported after the main app has
rendered. Where necessary, simple CSS shims are added to prevent visible
changes to the page.

In effect, this splits apart the first meaningful paint from the page
being fully interactive, and in the process improves first meaningful
paint by 10-15%.

BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/cf585f19edbbbfcfabd421a057e68a1d4cee860f
Cr-Commit-Position: refs/heads/master@{#420550}
==========

[commit-bot: I haz the power, 2016-09-23 02:38:13]

Patchset 7 (id:??) landed as
https://crrev.com/cf585f19edbbbfcfabd421a057e68a1d4cee860f
Cr-Commit-Position: refs/heads/master@{#420550}