Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4346)

Unified Diff: chrome/browser/resources/md_history/PRESUBMIT.py

Issue 2264983002: MD History: Lazily load element files which are not needed for first paint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove flattenhtml, rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browser_resources.grd ('k') | chrome/browser/resources/md_history/app.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/md_history/PRESUBMIT.py
diff --git a/chrome/browser/resources/md_history/PRESUBMIT.py b/chrome/browser/resources/md_history/PRESUBMIT.py
index 485e8861401a22fd4117142f1088dea8618d1ce4..2c041a4c7e7125da3426f63f4a4332936ac540cd 100644
--- a/chrome/browser/resources/md_history/PRESUBMIT.py
+++ b/chrome/browser/resources/md_history/PRESUBMIT.py
@@ -11,16 +11,16 @@ def CheckChangeOnUpload(input_api, output_api):
def _is_md_history_file(path):
return (path.startswith('chrome/browser/resources/md_history') and
(not path.endswith('externs.js')) and
- (not path.endswith('app.crisper.js')) and
- (not path.endswith('app.vulcanized.html')) and
+ (not path.endswith('crisper.js')) and
+ (not path.endswith('vulcanized.html')) and
(path.endswith('js') or path.endswith('html')))
- def _affects_file(filename, paths):
- return any([filename in path for path in paths])
-
paths = [x.LocalPath() for x in input_api.change.AffectedFiles()]
earliest_vulcanize_change = min(os.path.getmtime(x) for x in
- ['app.vulcanized.html', 'app.crisper.js'])
+ ['app.vulcanized.html',
+ 'app.crisper.js',
+ 'lazy_load.vulcanized.html',
+ 'lazy_load.crisper.js'])
history_changes = filter(_is_md_history_file, paths)
latest_history_change = 0
if history_changes:
« no previous file with comments | « chrome/browser/browser_resources.grd ('k') | chrome/browser/resources/md_history/app.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698