Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chrome/browser/browser_resources.grd

Issue 2264983002: MD History: Lazily load element files which are not needed for first paint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: calamity@ review Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/PRESUBMIT.py ('k') | chrome/browser/resources/md_downloads/vulcanized.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="UTF-8"?> 1 <?xml version="1.0" encoding="UTF-8"?>
2 <grit latest_public_release="0" current_release="1" output_all_resource_defines= "false"> 2 <grit latest_public_release="0" current_release="1" output_all_resource_defines= "false">
3 <outputs> 3 <outputs>
4 <output filename="grit/browser_resources.h" type="rc_header"> 4 <output filename="grit/browser_resources.h" type="rc_header">
5 <emit emit_type='prepend'></emit> 5 <emit emit_type='prepend'></emit>
6 </output> 6 </output>
7 <output filename="browser_resources.pak" type="data_package" /> 7 <output filename="browser_resources.pak" type="data_package" />
8 </outputs> 8 </outputs>
9 <release seq="1"> 9 <release seq="1">
10 <structures> 10 <structures>
(...skipping 221 matching lines...) Expand 10 before | Expand all | Expand 10 after
232 <include name="IDR_MD_HISTORY_CONSTANTS_HTML" file="resources\md_history \constants.html" type="BINDATA" /> 232 <include name="IDR_MD_HISTORY_CONSTANTS_HTML" file="resources\md_history \constants.html" type="BINDATA" />
233 <include name="IDR_MD_HISTORY_CONSTANTS_JS" file="resources\md_history\c onstants.js" type="BINDATA" /> 233 <include name="IDR_MD_HISTORY_CONSTANTS_JS" file="resources\md_history\c onstants.js" type="BINDATA" />
234 <include name="IDR_MD_HISTORY_HISTORY_HTML" file="resources\md_history\h istory.html" flattenhtml="true" type="BINDATA" /> 234 <include name="IDR_MD_HISTORY_HISTORY_HTML" file="resources\md_history\h istory.html" flattenhtml="true" type="BINDATA" />
235 <include name="IDR_MD_HISTORY_HISTORY_JS" file="resources\md_history\his tory.js" type="BINDATA" /> 235 <include name="IDR_MD_HISTORY_HISTORY_JS" file="resources\md_history\his tory.js" type="BINDATA" />
236 <include name="IDR_MD_HISTORY_IMAGES_100_SIGN_IN_PROMO_PNG" file="resour ces\md_history\images\100\sign_in_promo.png" type="BINDATA" /> 236 <include name="IDR_MD_HISTORY_IMAGES_100_SIGN_IN_PROMO_PNG" file="resour ces\md_history\images\100\sign_in_promo.png" type="BINDATA" />
237 <include name="IDR_MD_HISTORY_IMAGES_200_SIGN_IN_PROMO_PNG" file="resour ces\md_history\images\200\sign_in_promo.png" type="BINDATA" /> 237 <include name="IDR_MD_HISTORY_IMAGES_200_SIGN_IN_PROMO_PNG" file="resour ces\md_history\images\200\sign_in_promo.png" type="BINDATA" />
238 <if expr="use_vulcanize"> 238 <if expr="use_vulcanize">
239 <then> 239 <then>
240 <include name="IDR_MD_HISTORY_APP_VULCANIZED_HTML" file="resources\m d_history\app.vulcanized.html" flattenhtml="true" allowexternalscript="true" typ e="BINDATA" /> 240 <include name="IDR_MD_HISTORY_APP_VULCANIZED_HTML" file="resources\m d_history\app.vulcanized.html" flattenhtml="true" allowexternalscript="true" typ e="BINDATA" />
241 <include name="IDR_MD_HISTORY_APP_CRISPER_JS" file="resources\md_his tory\app.crisper.js" flattenhtml="true" allowexternalscript="true" type="BINDATA " /> 241 <include name="IDR_MD_HISTORY_APP_CRISPER_JS" file="resources\md_his tory\app.crisper.js" flattenhtml="true" allowexternalscript="true" type="BINDATA " />
242 <include name="IDR_MD_HISTORY_LAZY_LOAD_VULCANIZED_HTML" file="resou rces\md_history\lazy_load.vulcanized.html" flattenhtml="true" allowexternalscrip t="true" type="BINDATA" />
Dan Beam 2016/09/22 04:42:06 why do you need flattenhtml="true"?
tsergeant 2016/09/23 01:19:51 Hmmm, no reason. I've removed it from all the new
243 <include name="IDR_MD_HISTORY_LAZY_LOAD_CRISPER_JS" file="resources\ md_history\lazy_load.crisper.js" flattenhtml="true" allowexternalscript="true" t ype="BINDATA" />
242 </then> 244 </then>
243 <else> 245 <else>
244 <include name="IDR_MD_HISTORY_APP_HTML" file="resources\md_history\a pp.html" type="BINDATA" /> 246 <include name="IDR_MD_HISTORY_APP_HTML" file="resources\md_history\a pp.html" type="BINDATA" />
245 <include name="IDR_MD_HISTORY_APP_JS" file="resources\md_history\app .js" type="BINDATA" /> 247 <include name="IDR_MD_HISTORY_APP_JS" file="resources\md_history\app .js" type="BINDATA" />
246 <include name="IDR_MD_HISTORY_BROWSER_SERVICE_HTML" file="resources\ md_history\browser_service.html" type="BINDATA" /> 248 <include name="IDR_MD_HISTORY_BROWSER_SERVICE_HTML" file="resources\ md_history\browser_service.html" type="BINDATA" />
247 <include name="IDR_MD_HISTORY_BROWSER_SERVICE_JS" file="resources\md _history\browser_service.js" type="BINDATA" /> 249 <include name="IDR_MD_HISTORY_BROWSER_SERVICE_JS" file="resources\md _history\browser_service.js" type="BINDATA" />
248 <include name="IDR_MD_HISTORY_GROUPED_LIST_HTML" file="resources\md_ history\grouped_list.html" type="BINDATA" /> 250 <include name="IDR_MD_HISTORY_GROUPED_LIST_HTML" file="resources\md_ history\grouped_list.html" type="BINDATA" />
249 <include name="IDR_MD_HISTORY_GROUPED_LIST_JS" file="resources\md_hi story\grouped_list.js" type="BINDATA" /> 251 <include name="IDR_MD_HISTORY_GROUPED_LIST_JS" file="resources\md_hi story\grouped_list.js" type="BINDATA" />
250 <include name="IDR_MD_HISTORY_HISTORY_ITEM_HTML" file="resources\md_ history\history_item.html" type="BINDATA" /> 252 <include name="IDR_MD_HISTORY_HISTORY_ITEM_HTML" file="resources\md_ history\history_item.html" type="BINDATA" />
251 <include name="IDR_MD_HISTORY_HISTORY_ITEM_JS" file="resources\md_hi story\history_item.js" type="BINDATA" /> 253 <include name="IDR_MD_HISTORY_HISTORY_ITEM_JS" file="resources\md_hi story\history_item.js" type="BINDATA" />
252 <include name="IDR_MD_HISTORY_HISTORY_LIST_BEHAVIOR_HTML" file="reso urces\md_history\history_list_behavior.html" type="BINDATA" /> 254 <include name="IDR_MD_HISTORY_HISTORY_LIST_BEHAVIOR_HTML" file="reso urces\md_history\history_list_behavior.html" type="BINDATA" />
253 <include name="IDR_MD_HISTORY_HISTORY_LIST_BEHAVIOR_JS" file="resour ces\md_history\history_list_behavior.js" type="BINDATA" /> 255 <include name="IDR_MD_HISTORY_HISTORY_LIST_BEHAVIOR_JS" file="resour ces\md_history\history_list_behavior.js" type="BINDATA" />
254 <include name="IDR_MD_HISTORY_HISTORY_LIST_HTML" file="resources\md_ history\history_list.html" type="BINDATA" /> 256 <include name="IDR_MD_HISTORY_HISTORY_LIST_HTML" file="resources\md_ history\history_list.html" type="BINDATA" />
255 <include name="IDR_MD_HISTORY_HISTORY_LIST_JS" file="resources\md_hi story\history_list.js" type="BINDATA" /> 257 <include name="IDR_MD_HISTORY_HISTORY_LIST_JS" file="resources\md_hi story\history_list.js" type="BINDATA" />
256 <include name="IDR_MD_HISTORY_HISTORY_TOOLBAR_HTML" file="resources\ md_history\history_toolbar.html" type="BINDATA" /> 258 <include name="IDR_MD_HISTORY_HISTORY_TOOLBAR_HTML" file="resources\ md_history\history_toolbar.html" type="BINDATA" />
257 <include name="IDR_MD_HISTORY_HISTORY_TOOLBAR_JS" file="resources\md _history\history_toolbar.js" type="BINDATA" /> 259 <include name="IDR_MD_HISTORY_HISTORY_TOOLBAR_JS" file="resources\md _history\history_toolbar.js" type="BINDATA" />
258 <include name="IDR_MD_HISTORY_ICONS_HTML" file="resources\md_history \icons.html" type="BINDATA" /> 260 <include name="IDR_MD_HISTORY_ICONS_HTML" file="resources\md_history \icons.html" type="BINDATA" />
261 <include name="IDR_MD_HISTORY_LAZY_LOAD_HTML" file="resources\md_his tory\lazy_load.html" flattenhtml="true" type="BINDATA" />
259 <include name="IDR_MD_HISTORY_LIST_CONTAINER_HTML" file="resources\m d_history\list_container.html" type="BINDATA" /> 262 <include name="IDR_MD_HISTORY_LIST_CONTAINER_HTML" file="resources\m d_history\list_container.html" type="BINDATA" />
260 <include name="IDR_MD_HISTORY_LIST_CONTAINER_JS" file="resources\md_ history\list_container.js" type="BINDATA" /> 263 <include name="IDR_MD_HISTORY_LIST_CONTAINER_JS" file="resources\md_ history\list_container.js" type="BINDATA" />
261 <include name="IDR_MD_HISTORY_SEARCHED_LABEL_HTML" file="resources\m d_history\searched_label.html" type="BINDATA" /> 264 <include name="IDR_MD_HISTORY_SEARCHED_LABEL_HTML" file="resources\m d_history\searched_label.html" type="BINDATA" />
262 <include name="IDR_MD_HISTORY_SEARCHED_LABEL_JS" file="resources\md_ history\searched_label.js" type="BINDATA" /> 265 <include name="IDR_MD_HISTORY_SEARCHED_LABEL_JS" file="resources\md_ history\searched_label.js" type="BINDATA" />
263 <include name="IDR_MD_HISTORY_SHARED_STYLE_HTML" file="resources\md_ history\shared_style.html" type="BINDATA" /> 266 <include name="IDR_MD_HISTORY_SHARED_STYLE_HTML" file="resources\md_ history\shared_style.html" type="BINDATA" />
264 <include name="IDR_MD_HISTORY_SHARED_VARS_HTML" file="resources\md_h istory\shared_vars.html" type="BINDATA" /> 267 <include name="IDR_MD_HISTORY_SHARED_VARS_HTML" file="resources\md_h istory\shared_vars.html" type="BINDATA" />
265 <include name="IDR_MD_HISTORY_SIDE_BAR_HTML" file="resources\md_hist ory\side_bar.html" type="BINDATA" /> 268 <include name="IDR_MD_HISTORY_SIDE_BAR_HTML" file="resources\md_hist ory\side_bar.html" type="BINDATA" />
266 <include name="IDR_MD_HISTORY_SIDE_BAR_JS" file="resources\md_histor y\side_bar.js" type="BINDATA" /> 269 <include name="IDR_MD_HISTORY_SIDE_BAR_JS" file="resources\md_histor y\side_bar.js" type="BINDATA" />
267 <include name="IDR_MD_HISTORY_SYNCED_DEVICE_CARD_HTML" file="resourc es\md_history\synced_device_card.html" type="BINDATA" /> 270 <include name="IDR_MD_HISTORY_SYNCED_DEVICE_CARD_HTML" file="resourc es\md_history\synced_device_card.html" type="BINDATA" />
268 <include name="IDR_MD_HISTORY_SYNCED_DEVICE_CARD_JS" file="resources \md_history\synced_device_card.js" type="BINDATA" /> 271 <include name="IDR_MD_HISTORY_SYNCED_DEVICE_CARD_JS" file="resources \md_history\synced_device_card.js" type="BINDATA" />
(...skipping 316 matching lines...) Expand 10 before | Expand all | Expand 10 after
585 <include name="IDR_CAST_FAVICON" file="resources\cast\cast_favicon.ico" type="BINDATA" /> 588 <include name="IDR_CAST_FAVICON" file="resources\cast\cast_favicon.ico" type="BINDATA" />
586 </if> 589 </if>
587 <if expr="not is_android and not is_ios"> 590 <if expr="not is_android and not is_ios">
588 <include name="IDR_IME_WINDOW_CLOSE" file="resources\input_ime\ime_windo w_close.png" type="BINDATA" /> 591 <include name="IDR_IME_WINDOW_CLOSE" file="resources\input_ime\ime_windo w_close.png" type="BINDATA" />
589 <include name="IDR_IME_WINDOW_CLOSE_C" file="resources\input_ime\ime_win dow_close_click.png" type="BINDATA" /> 592 <include name="IDR_IME_WINDOW_CLOSE_C" file="resources\input_ime\ime_win dow_close_click.png" type="BINDATA" />
590 <include name="IDR_IME_WINDOW_CLOSE_H" file="resources\input_ime\ime_win dow_close_hover.png" type="BINDATA" /> 593 <include name="IDR_IME_WINDOW_CLOSE_H" file="resources\input_ime\ime_win dow_close_hover.png" type="BINDATA" />
591 </if> 594 </if>
592 </includes> 595 </includes>
593 </release> 596 </release>
594 </grit> 597 </grit>
OLDNEW
« no previous file with comments | « chrome/browser/PRESUBMIT.py ('k') | chrome/browser/resources/md_downloads/vulcanized.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698