Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2264673002: [CUPS] Implement Advanced section in CUPS printer details page. (Closed)

Created:
4 years, 4 months ago by xdai1
Modified:
4 years, 3 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[CUPS] Implement Advanced section in CUPS printer details page. BUG=626752 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/b09439cf49da926dc2c4773cccc06b9aa27606ee Cr-Commit-Position: refs/heads/master@{#414193}

Patch Set 1 #

Patch Set 2 : Address michaelpg@'s comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -0 lines) Patch
M chrome/app/settings_strings.grdp View 1 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/printing_page/cups_printer_details_page.html View 1 2 chunks +27 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/printing_page/cups_printer_details_page.js View 2 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
xdai1
michaelpg@, could you help review this CL please? Thanks!
4 years, 4 months ago (2016-08-19 20:53:30 UTC) #4
xdai1
On 2016/08/19 20:53:30, xdai1 wrote: > michaelpg@, could you help review this CL please? Thanks! ...
4 years, 4 months ago (2016-08-19 20:55:07 UTC) #5
michaelpg
looks good, but needs i18n
4 years, 4 months ago (2016-08-20 00:52:15 UTC) #8
xdai1
i18n added. Please take another look, thanks for your review!
4 years, 3 months ago (2016-08-22 17:40:17 UTC) #9
xdai1
On 2016/08/22 17:40:17, xdai1 wrote: > i18n added. Please take another look, thanks for your ...
4 years, 3 months ago (2016-08-23 22:16:03 UTC) #10
michaelpg
apologies, I looked yesterday and forgot to lgtm. lgtm!
4 years, 3 months ago (2016-08-24 18:05:18 UTC) #11
xdai1
On 2016/08/24 18:05:18, michaelpg wrote: > apologies, I looked yesterday and forgot to lgtm. lgtm! ...
4 years, 3 months ago (2016-08-24 18:29:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2264673002/20001
4 years, 3 months ago (2016-08-24 18:30:22 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/267951)
4 years, 3 months ago (2016-08-24 20:36:02 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2264673002/20001
4 years, 3 months ago (2016-08-24 21:45:53 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-24 23:20:50 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-08-24 23:22:49 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b09439cf49da926dc2c4773cccc06b9aa27606ee
Cr-Commit-Position: refs/heads/master@{#414193}

Powered by Google App Engine
This is Rietveld 408576698