Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4768)

Unified Diff: chrome/browser/resources/settings/printing_page/cups_printer_details_page.html

Issue 2264673002: [CUPS] Implement Advanced section in CUPS printer details page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address michaelpg@'s comments. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/printing_page/cups_printer_details_page.html
diff --git a/chrome/browser/resources/settings/printing_page/cups_printer_details_page.html b/chrome/browser/resources/settings/printing_page/cups_printer_details_page.html
index 8745ac1ba5f80b0940f3400c5b21ea19d311fed8..e565f30e5f87b80ea981881b285117a6bb4edd56 100644
--- a/chrome/browser/resources/settings/printing_page/cups_printer_details_page.html
+++ b/chrome/browser/resources/settings/printing_page/cups_printer_details_page.html
@@ -1,4 +1,6 @@
+<link rel="import" href="chrome://resources/cr_elements/cr_expand_button/cr_expand_button.html">
<link rel="import" href="chrome://resources/html/polymer.html">
+<link rel="import" href="chrome://resources/polymer/v1_0/iron-collapse/iron-collapse.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input.html">
<link rel="import" href="/settings_shared_css.html">
@@ -30,6 +32,31 @@
<div class="secondary">[[printer.printerModel]]</div>
</div>
</div>
+ <!-- TODO(xdai): Add printerStatus. -->
+
+ <!-- Advanced toggle -->
+ <div class="settings-box" actionable on-tap="toggleAdvancedExpanded_">
+ <div class="start">$i18n{printerDetailsAdvanced}</div>
+ <cr-expand-button id="expandButton" expanded="{{advancedExpanded}}">
+ </cr-expand-button>
+ </div>
+ <!-- Advanced section -->
+ <iron-collapse opened="[[advancedExpanded]]">
+ <div class="list-frame vertical-list">
+ <div class="list-item setting-box two-line">
+ <div class="start">
+ <div>$i18n{printerAddress}</div>
+ <div class="secondary">[[printer.printerAddress]]</div>
+ </div>
+ </div>
+ <div class="list-item setting-box two-line">
+ <div class="start">
+ <div>$i18n{printerProtocol}</div>
+ <div class="secondary">[[printer.printerProtocol]]</div>
+ </div>
+ </div>
+ </div>
+ </iron-collapse>
</template>
<script src="cups_printer_details_page.js"></script>
</dom-module>
« no previous file with comments | « chrome/app/settings_strings.grdp ('k') | chrome/browser/resources/settings/printing_page/cups_printer_details_page.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698