Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Unified Diff: chrome/browser/resources/settings/printing_page/cups_printer_details_page.js

Issue 2264673002: [CUPS] Implement Advanced section in CUPS printer details page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address michaelpg@'s comments. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/printing_page/cups_printer_details_page.js
diff --git a/chrome/browser/resources/settings/printing_page/cups_printer_details_page.js b/chrome/browser/resources/settings/printing_page/cups_printer_details_page.js
index 61cefab6863ceb6eb2a19fe4b55f0354063ba299..931c553fbd4816176a1a5a19ad99b52e41fff33b 100644
--- a/chrome/browser/resources/settings/printing_page/cups_printer_details_page.js
+++ b/chrome/browser/resources/settings/printing_page/cups_printer_details_page.js
@@ -15,6 +15,11 @@ Polymer({
type: Object,
notify: true,
},
+
+ advancedExpanded: {
+ type: Boolean,
+ value: false,
+ },
},
/** @private {settings.CupsPrintersBrowserProxy} */
@@ -33,4 +38,14 @@ Polymer({
this.browserProxy_.updateCupsPrinter(this.printer.printerId,
this.printer.printerName);
},
+
+ /**
+ * @param {Event} event
+ * @private
+ */
+ toggleAdvancedExpanded_: function(event) {
+ if (event.target.id == 'expandButton')
+ return; // Already handled.
+ this.advancedExpanded = !this.advancedExpanded;
+ },
});

Powered by Google App Engine
This is Rietveld 408576698