Move createCrossThreadTask to ExecutionContextTask.h

Move createCrossThreadTask to ExecutionContextTask.h

Move createCrossThreadTask to ExecutionContextTask.h so that
both same thread and cross thread versions of createTask are in the
same header file.
Currently createCrossThreadTask is in CrossThreadTask.h,
but the implementation is a few lines of code, so merging it to
ExecutionContextTask.h and removing CrossThreadTask.h.

BUG=638839
Committed: https://crrev.com/84f5959aa09e9841e5aea9993247b46b42a60d9a
Cr-Commit-Position: refs/heads/master@{#414390}

[yuryu, 2016-08-23 06:39:34]

Description was changed from

==========
Move createCrossThreadTask to ExecutionContextTask.h

createSameThreadTask is in ExecutionContextTask.h and
createCrossThreadTask was in CrossThreadTask.h, but the implementation
is currently a few lines of code, so merging it to
ExecutionContextTask.h and removing CrossThreadTask.h.

BUG=638839
==========

to

==========
Move createCrossThreadTask to ExecutionContextTask.h

createSameThreadTask is in ExecutionContextTask.h and
createCrossThreadTask was in CrossThreadTask.h, but the implementation
is currently a few lines of code, so merging it to
ExecutionContextTask.h and removing CrossThreadTask.h.

BUG=638839
==========

[yuryu, 2016-08-23 06:39:35]

yuryu@chromium.org changed reviewers:
+ haraken@chromium.org, hiroshige@chromium.org, tzik@chromium.org

[tzik, 2016-08-23 07:08:15]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 07:08:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 07:26:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 07:26:45]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yuryu, 2016-08-24 07:18:08]

The CQ bit was checked by yuryu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 07:18:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 09:44:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 09:44:50]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[yuryu, 2016-08-25 06:50:31]

Description was changed from

==========
Move createCrossThreadTask to ExecutionContextTask.h

createSameThreadTask is in ExecutionContextTask.h and
createCrossThreadTask was in CrossThreadTask.h, but the implementation
is currently a few lines of code, so merging it to
ExecutionContextTask.h and removing CrossThreadTask.h.

BUG=638839
==========

to

==========
Move createCrossThreadTask to ExecutionContextTask.h

Move createCrossThreadTask to ExecutionContextTask.h so that
both same thread and cross thread versions of createTask are in the
same header file.
Currently createCrossThreadTask is in CrossThreadTask.h, but the implementation
is a few lines of code, so merging it to
ExecutionContextTask.h and removing CrossThreadTask.h.

BUG=638839
==========

[yuryu, 2016-08-25 06:50:54]

Description was changed from

==========
Move createCrossThreadTask to ExecutionContextTask.h

Move createCrossThreadTask to ExecutionContextTask.h so that
both same thread and cross thread versions of createTask are in the
same header file.
Currently createCrossThreadTask is in CrossThreadTask.h, but the implementation
is a few lines of code, so merging it to
ExecutionContextTask.h and removing CrossThreadTask.h.

BUG=638839
==========

to

==========
Move createCrossThreadTask to ExecutionContextTask.h

Move createCrossThreadTask to ExecutionContextTask.h so that
both same thread and cross thread versions of createTask are in the
same header file.
Currently createCrossThreadTask is in CrossThreadTask.h,
but the implementation is a few lines of code, so merging it to
ExecutionContextTask.h and removing CrossThreadTask.h.

BUG=638839
==========

[haraken, 2016-08-25 07:41:06]

https://codereview.chromium.org/2264543002/diff/90001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/CrossThreadTaskTest.cpp (left):

https://codereview.chromium.org/2264543002/diff/90001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/CrossThreadTaskTest.cpp:44:
TEST_F(CrossThreadTaskTest, CreateForGarbageCollectedMethod)

Do we want to remove tests in this file?

[yuryu, 2016-08-25 08:08:57]

On 2016/08/25 07:41:06, haraken wrote:
>
https://codereview.chromium.org/2264543002/diff/90001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/dom/CrossThreadTaskTest.cpp (left):
> 
>
https://codereview.chromium.org/2264543002/diff/90001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/dom/CrossThreadTaskTest.cpp:44:
> TEST_F(CrossThreadTaskTest, CreateForGarbageCollectedMethod)
> 
> Do we want to remove tests in this file?

I renamed the file to ExecutionContextTaskTest.cpp
(https://codereview.chromium.org/2264543002/patch/90001/100006) and added to
core.gypi(https://codereview.chromium.org/2264543002/patch/90001/100003). Does
this make sense?

[haraken, 2016-08-25 08:11:14]

On 2016/08/25 08:08:57, yuryu wrote:
> On 2016/08/25 07:41:06, haraken wrote:
> >
>
https://codereview.chromium.org/2264543002/diff/90001/third_party/WebKit/Sour...
> > File third_party/WebKit/Source/core/dom/CrossThreadTaskTest.cpp (left):
> > 
> >
>
https://codereview.chromium.org/2264543002/diff/90001/third_party/WebKit/Sour...
> > third_party/WebKit/Source/core/dom/CrossThreadTaskTest.cpp:44:
> > TEST_F(CrossThreadTaskTest, CreateForGarbageCollectedMethod)
> > 
> > Do we want to remove tests in this file?
> 
> I renamed the file to ExecutionContextTaskTest.cpp
> (https://codereview.chromium.org/2264543002/patch/90001/100006) and added to
> core.gypi(https://codereview.chromium.org/2264543002/patch/90001/100003). Does
> this make sense?

Ah, sorry. I missed that.

LGTM.

[yuryu, 2016-08-25 08:40:31]

The CQ bit was checked by yuryu@chromium.org

[commit-bot: I haz the power, 2016-08-25 08:40:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yuryu, 2016-08-25 08:41:19]

On 2016/08/25 08:11:14, haraken wrote:
> LGTM.

Thanks!

[commit-bot: I haz the power, 2016-08-25 09:58:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 09:58:29]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[yuryu, 2016-08-25 10:26:46]

The CQ bit was checked by yuryu@chromium.org

[commit-bot: I haz the power, 2016-08-25 10:27:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 11:07:24]

Description was changed from

==========
Move createCrossThreadTask to ExecutionContextTask.h

Move createCrossThreadTask to ExecutionContextTask.h so that
both same thread and cross thread versions of createTask are in the
same header file.
Currently createCrossThreadTask is in CrossThreadTask.h,
but the implementation is a few lines of code, so merging it to
ExecutionContextTask.h and removing CrossThreadTask.h.

BUG=638839
==========

to

==========
Move createCrossThreadTask to ExecutionContextTask.h

Move createCrossThreadTask to ExecutionContextTask.h so that
both same thread and cross thread versions of createTask are in the
same header file.
Currently createCrossThreadTask is in CrossThreadTask.h,
but the implementation is a few lines of code, so merging it to
ExecutionContextTask.h and removing CrossThreadTask.h.

BUG=638839
==========

[commit-bot: I haz the power, 2016-08-25 11:07:25]

Committed patchset #6 (id:90001)

[commit-bot: I haz the power, 2016-08-25 11:09:10]

Description was changed from

==========
Move createCrossThreadTask to ExecutionContextTask.h

Move createCrossThreadTask to ExecutionContextTask.h so that
both same thread and cross thread versions of createTask are in the
same header file.
Currently createCrossThreadTask is in CrossThreadTask.h,
but the implementation is a few lines of code, so merging it to
ExecutionContextTask.h and removing CrossThreadTask.h.

BUG=638839
==========

to

==========
Move createCrossThreadTask to ExecutionContextTask.h

Move createCrossThreadTask to ExecutionContextTask.h so that
both same thread and cross thread versions of createTask are in the
same header file.
Currently createCrossThreadTask is in CrossThreadTask.h,
but the implementation is a few lines of code, so merging it to
ExecutionContextTask.h and removing CrossThreadTask.h.

BUG=638839

Committed: https://crrev.com/84f5959aa09e9841e5aea9993247b46b42a60d9a
Cr-Commit-Position: refs/heads/master@{#414390}
==========

[commit-bot: I haz the power, 2016-08-25 11:09:11]

Patchset 6 (id:??) landed as
https://crrev.com/84f5959aa09e9841e5aea9993247b46b42a60d9a
Cr-Commit-Position: refs/heads/master@{#414390}

[hiroshige, 2016-08-25 12:51:39]

lgtm!