Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Unified Diff: third_party/WebKit/Source/core/dom/CrossThreadTask.h

Issue 2264543002: Move createCrossThreadTask to ExecutionContextTask.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix tests Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/CrossThreadTask.h
diff --git a/third_party/WebKit/Source/core/dom/CrossThreadTask.h b/third_party/WebKit/Source/core/dom/CrossThreadTask.h
deleted file mode 100644
index fcaca1fc69282a3e8b7490b71f428a618dd14d3f..0000000000000000000000000000000000000000
--- a/third_party/WebKit/Source/core/dom/CrossThreadTask.h
+++ /dev/null
@@ -1,93 +0,0 @@
-/*
- * Copyright (C) 2009-2010 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are
- * met:
- *
- * * Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * * Redistributions in binary form must reproduce the above
- * copyright notice, this list of conditions and the following disclaimer
- * in the documentation and/or other materials provided with the
- * distribution.
- * * Neither the name of Google Inc. nor the names of its
- * contributors may be used to endorse or promote products derived from
- * this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#ifndef CrossThreadTask_h
-#define CrossThreadTask_h
-
-#include "core/dom/ExecutionContext.h"
-#include "core/dom/ExecutionContextTask.h"
-#include "platform/CrossThreadFunctional.h"
-#include <type_traits>
-
-namespace blink {
-
-// createCrossThreadTask(...) is ExecutionContextTask version of
-// crossThreadBind().
-// Using WTF::bind() directly is not thread-safe due to temporary objects, see
-// https://crbug.com/390851 for details.
-//
-// Example:
-// void func1(int, const String&);
-// createCrossThreadTask(func1, 42, str);
-// func1(42, str2) will be called, where |str2| is a deep copy of
-// |str| (created by str.isolatedCopy()).
-//
-// Don't (if you pass the task across threads):
-// bind(func1, 42, str);
-// bind(func1, 42, str.isolatedCopy());
-//
-// For functions:
-// void functionEC(MP1, ..., MPn, ExecutionContext*);
-// void function(MP1, ..., MPn);
-// class C {
-// void memberEC(MP1, ..., MPn, ExecutionContext*);
-// void member(MP1, ..., MPn);
-// };
-// We create tasks represented by std::unique_ptr<ExecutionContextTask>:
-// createCrossThreadTask(functionEC, const P1& p1, ..., const Pn& pn);
-// createCrossThreadTask(memberEC, C* ptr, const P1& p1, ..., const Pn& pn);
-// createCrossThreadTask(function, const P1& p1, ..., const Pn& pn);
-// createCrossThreadTask(member, C* ptr, const P1& p1, ..., const Pn& pn);
-// (|ptr| can also be WeakPtr<C> or other pointer-like types)
-// and then the following are called on the target thread:
-// functionEC(p1, ..., pn, context);
-// ptr->memberEC(p1, ..., pn, context);
-// function(p1, ..., pn);
-// ptr->member(p1, ..., pn);
-//
-// ExecutionContext:
-// |context| is supplied by the target thread.
-//
-// Deep copies by crossThreadBind():
-// |ptr|, |p1|, ..., |pn| are processed by crossThreadBind() and thus
-// CrossThreadCopier.
-// You don't have to call manually e.g. isolatedCopy().
-// To pass things that cannot be copied by CrossThreadCopier
-// (e.g. pointers), use crossThreadUnretained() explicitly.
-
-template<typename FunctionType, typename... P>
-std::unique_ptr<ExecutionContextTask> createCrossThreadTask(FunctionType function, P&&... parameters)
-{
- return internal::createCallClosureTask(crossThreadBind(function, std::forward<P>(parameters)...));
-}
-
-} // namespace blink
-
-#endif // CrossThreadTask_h

Powered by Google App Engine
This is Rietveld 408576698