Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: third_party/WebKit/Source/core/dom/CrossThreadTaskTest.cpp

Issue 2264543002: Move createCrossThreadTask to ExecutionContextTask.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix tests Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/CrossThreadTaskTest.cpp
diff --git a/third_party/WebKit/Source/core/dom/CrossThreadTaskTest.cpp b/third_party/WebKit/Source/core/dom/CrossThreadTaskTest.cpp
deleted file mode 100644
index c36c4265a49302f9c1a615266e4010acac3fd601..0000000000000000000000000000000000000000
--- a/third_party/WebKit/Source/core/dom/CrossThreadTaskTest.cpp
+++ /dev/null
@@ -1,68 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "core/dom/CrossThreadTask.h"
-
-#include "platform/heap/Handle.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-namespace blink {
-
-class GCObject : public GarbageCollectedFinalized<GCObject> {
-public:
- static int s_counter;
- GCObject() { ++s_counter; }
- ~GCObject() { --s_counter; }
- DEFINE_INLINE_TRACE() { }
- void run(GCObject*) { }
-};
-
-int GCObject::s_counter = 0;
-
-static void functionWithGarbageCollected(GCObject*)
-{
-}
-
-static void functionWithExecutionContext(GCObject*, ExecutionContext*)
-{
-}
-
-class CrossThreadTaskTest : public testing::Test {
-protected:
- void SetUp() override
- {
- GCObject::s_counter = 0;
- }
- void TearDown() override
- {
- ThreadHeap::collectGarbage(BlinkGC::NoHeapPointersOnStack, BlinkGC::GCWithSweep, BlinkGC::ForcedGC);
- ASSERT_EQ(0, GCObject::s_counter);
- }
-};
-
-TEST_F(CrossThreadTaskTest, CreateForGarbageCollectedMethod)
haraken 2016/08/25 07:41:06 Do we want to remove tests in this file?
-{
- std::unique_ptr<ExecutionContextTask> task1 = createCrossThreadTask(&GCObject::run, wrapCrossThreadPersistent(new GCObject), wrapCrossThreadPersistent(new GCObject));
- std::unique_ptr<ExecutionContextTask> task2 = createCrossThreadTask(&GCObject::run, wrapCrossThreadPersistent(new GCObject), wrapCrossThreadPersistent(new GCObject));
- ThreadHeap::collectGarbage(BlinkGC::NoHeapPointersOnStack, BlinkGC::GCWithSweep, BlinkGC::ForcedGC);
- EXPECT_EQ(4, GCObject::s_counter);
-}
-
-TEST_F(CrossThreadTaskTest, CreateForFunctionWithGarbageCollected)
-{
- std::unique_ptr<ExecutionContextTask> task1 = createCrossThreadTask(&functionWithGarbageCollected, wrapCrossThreadPersistent(new GCObject));
- std::unique_ptr<ExecutionContextTask> task2 = createCrossThreadTask(&functionWithGarbageCollected, wrapCrossThreadPersistent(new GCObject));
- ThreadHeap::collectGarbage(BlinkGC::NoHeapPointersOnStack, BlinkGC::GCWithSweep, BlinkGC::ForcedGC);
- EXPECT_EQ(2, GCObject::s_counter);
-}
-
-TEST_F(CrossThreadTaskTest, CreateForFunctionWithExecutionContext)
-{
- std::unique_ptr<ExecutionContextTask> task1 = createCrossThreadTask(&functionWithExecutionContext, wrapCrossThreadPersistent(new GCObject));
- std::unique_ptr<ExecutionContextTask> task2 = createCrossThreadTask(&functionWithExecutionContext, wrapCrossThreadPersistent(new GCObject));
- ThreadHeap::collectGarbage(BlinkGC::NoHeapPointersOnStack, BlinkGC::GCWithSweep, BlinkGC::ForcedGC);
- EXPECT_EQ(2, GCObject::s_counter);
-}
-
-} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/dom/CrossThreadTask.h ('k') | third_party/WebKit/Source/core/dom/Document.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698