Command buffers: ensure we only read immediate data once

Command buffers: ensure we only read immediate data once

Fizes various issues where we may be reading some immediate data twice:
- Gen*, Delete*
- InvalidateFramebuffer and friends
- DrawBuffersEXT
- Some Uniform* and VertexAttrib*
- Mailbox functions

BUG=597625, 597636
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/a17d2bcbccfda0480ed429897f243ca908dd6c15
Cr-Commit-Position: refs/heads/master@{#413962}

[piman, 2016-08-23 05:52:37]

Description was changed from

==========
Command buffers: ensure we only read immediate data once

Fizes various issues where we may be reading some immediate data twice:
- Gen*, Delete*
- InvalidateFramebuffer and friends
- DrawBuffersEXT
- Some Uniform* and VertexAttrib*
- Mailbox functions

BUG=597625, 597636
==========

to

==========
Command buffers: ensure we only read immediate data once

Fizes various issues where we may be reading some immediate data twice:
- Gen*, Delete*
- InvalidateFramebuffer and friends
- DrawBuffersEXT
- Some Uniform* and VertexAttrib*
- Mailbox functions

BUG=597625, 597636
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[piman, 2016-08-23 05:52:44]

The CQ bit was checked by piman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 05:52:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[piman, 2016-08-23 05:55:04]

piman@chromium.org changed reviewers:
+ sievers@chromium.org, zmo@chromium.org

[piman, 2016-08-23 05:55:04]

sievers, zmo: please review. Worth getting 2 pairs of eyes.

I have a follow up that makes all commands and immediate data volatile, that
needs these fixes. I wanted to separate out most of the active logic.

[commit-bot: I haz the power, 2016-08-23 07:00:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 07:00:53]

Dry run: Try jobs failed on following builders:
  linux_optional_gpu_tests_rel on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)

[Zhenyao Mo, 2016-08-23 16:18:01]

On 2016/08/23 05:55:04, piman wrote:
> sievers, zmo: please review. Worth getting 2 pairs of eyes.
> 
> I have a follow up that makes all commands and immediate data volatile, that
> needs these fixes. I wanted to separate out most of the active logic.

It seems the bots failures are real

[no sievers, 2016-08-23 21:09:04]

lgtm

https://codereview.chromium.org/2264253003/diff/1/gpu/command_buffer/build_gl...
File gpu/command_buffer/build_gles2_cmd_buffer.py (right):

https://codereview.chromium.org/2264253003/diff/1/gpu/command_buffer/build_gl...
gpu/command_buffer/build_gles2_cmd_buffer.py:6147: "    %(name)s_safe[i] =
%(name)s[i];\n"
maybe std::copy here?

[piman, 2016-08-23 23:24:53]

The CQ bit was checked by piman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 23:25:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[piman, 2016-08-23 23:27:50]

PTAL, fixed the failures (see DoUniform1iv) and added a unit test to cover it.

https://codereview.chromium.org/2264253003/diff/1/gpu/command_buffer/build_gl...
File gpu/command_buffer/build_gles2_cmd_buffer.py (right):

https://codereview.chromium.org/2264253003/diff/1/gpu/command_buffer/build_gl...
gpu/command_buffer/build_gles2_cmd_buffer.py:6147: "    %(name)s_safe[i] =
%(name)s[i];\n"
On 2016/08/23 21:09:04, sievers wrote:
> maybe std::copy here?

Done.

[Zhenyao Mo, 2016-08-23 23:53:06]

lgtm with one nit

https://codereview.chromium.org/2264253003/diff/40001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/2264253003/diff/40001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:16164: back_buffer_draw_buffer_
= buf;
Here we should store the user buffer, not the mapped buffer. (you could move
this line above #16161.

[piman, 2016-08-24 00:10:33]

https://codereview.chromium.org/2264253003/diff/40001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/2264253003/diff/40001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:16164: back_buffer_draw_buffer_
= buf;
On 2016/08/23 23:53:06, Zhenyao Mo wrote:
> Here we should store the user buffer, not the mapped buffer. (you could move
> this line above #16161.

Thanks for the catch, done.

[piman, 2016-08-24 00:10:42]

The CQ bit was checked by piman@chromium.org

[piman, 2016-08-24 00:10:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
sievers@chromium.org, zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/2264253003/#ps60001
(title: "Keep track of the correct draw buffer")

[commit-bot: I haz the power, 2016-08-24 00:11:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 02:17:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 02:17:37]

Try jobs failed on following builders:
  win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)

[Zhenyao Mo, 2016-08-24 02:28:59]

The CQ bit was checked by zmo@chromium.org

[commit-bot: I haz the power, 2016-08-24 02:29:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 03:05:48]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-24 03:07:21]

Description was changed from

==========
Command buffers: ensure we only read immediate data once

Fizes various issues where we may be reading some immediate data twice:
- Gen*, Delete*
- InvalidateFramebuffer and friends
- DrawBuffersEXT
- Some Uniform* and VertexAttrib*
- Mailbox functions

BUG=597625, 597636
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Command buffers: ensure we only read immediate data once

Fizes various issues where we may be reading some immediate data twice:
- Gen*, Delete*
- InvalidateFramebuffer and friends
- DrawBuffersEXT
- Some Uniform* and VertexAttrib*
- Mailbox functions

BUG=597625, 597636
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/a17d2bcbccfda0480ed429897f243ca908dd6c15
Cr-Commit-Position: refs/heads/master@{#413962}
==========

[commit-bot: I haz the power, 2016-08-24 03:07:22]

Patchset 4 (id:??) landed as
https://crrev.com/a17d2bcbccfda0480ed429897f243ca908dd6c15
Cr-Commit-Position: refs/heads/master@{#413962}