Command buffers: ensure we only read immediate data once

gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef GPU_COMMAND_BUFFER_SERVICE_GLES2_CMD_DECODER_UNITTEST_BASE_H_
 #define GPU_COMMAND_BUFFER_SERVICE_GLES2_CMD_DECODER_UNITTEST_BASE_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 52 matching lines @@
   // certain commands.
   template <typename T, int id>
   void SpecializedSetup(bool valid) {
   }
 
   template <typename T>
   T* GetImmediateAs() {
     return reinterpret_cast<T*>(immediate_buffer_);
   }
 
-  template <typename T, typename Command>
-  T GetImmediateDataAs(Command* cmd) {
-    return reinterpret_cast<T>(ImmediateDataAddress(cmd));
-  }
-
   void ClearSharedMemory() {
     engine_->ClearSharedMemory();
   }
 
   void SetUp() override;
   void TearDown() override;
 
   template <typename T>
   error::Error ExecuteCmd(const T& cmd) {
     static_assert(T::kArgFlags == cmd::kFixed,
@@ skipping 478 matching lines @@
   static const GLint kBadAttribIndex = kNumVertexAttribs;
 
   static const GLint kMaxUniformLength = 12;
   static const char* kUniform1Name;
   static const char* kUniform2Name;
   static const char* kUniform3Name;
   static const char* kUniform4Name;
   static const char* kUniform5Name;
   static const char* kUniform6Name;
   static const char* kUniform7Name;
+  static const char* kUniform8Name;
   static const GLint kUniform1Size = 1;
   static const GLint kUniform2Size = 3;
   static const GLint kUniform3Size = 2;
   static const GLint kUniform4Size = 1;
   static const GLint kUniform5Size = 1;
   static const GLint kUniform6Size = 1;
   static const GLint kUniform7Size = 1;
+  static const GLint kUniform8Size = 2;
   static const GLint kUniform1RealLocation = 3;
   static const GLint kUniform2RealLocation = 10;
   static const GLint kUniform2ElementRealLocation = 12;
   static const GLint kUniform3RealLocation = 20;
   static const GLint kUniform4RealLocation = 22;
   static const GLint kUniform5RealLocation = 30;
   static const GLint kUniform6RealLocation = 32;
   static const GLint kUniform7RealLocation = 44;
+  static const GLint kUniform8RealLocation = 56;
   static const GLint kUniform1FakeLocation = 0;               // These are
   static const GLint kUniform2FakeLocation = 1;               // hardcoded
   static const GLint kUniform2ElementFakeLocation = 0x10001;  // to match
   static const GLint kUniform3FakeLocation = 2;               // ProgramManager.
   static const GLint kUniform4FakeLocation = 3;               //
   static const GLint kUniform5FakeLocation = 4;               //
   static const GLint kUniform6FakeLocation = 5;               //
   static const GLint kUniform7FakeLocation = 6;               //
+  static const GLint kUniform8FakeLocation = 7;               //
   static const GLint kUniform1DesiredLocation = -1;
   static const GLint kUniform2DesiredLocation = -1;
   static const GLint kUniform3DesiredLocation = -1;
   static const GLint kUniform4DesiredLocation = -1;
   static const GLint kUniform5DesiredLocation = -1;
   static const GLint kUniform6DesiredLocation = -1;
   static const GLint kUniform7DesiredLocation = -1;
+  static const GLint kUniform8DesiredLocation = -1;
   static const GLenum kUniform1Type = GL_SAMPLER_2D;
   static const GLenum kUniform2Type = GL_INT_VEC2;
   static const GLenum kUniform3Type = GL_FLOAT_VEC3;
   static const GLenum kUniform4Type = GL_UNSIGNED_INT;
   static const GLenum kUniform5Type = GL_UNSIGNED_INT_VEC2;
   static const GLenum kUniform6Type = GL_UNSIGNED_INT_VEC3;
   static const GLenum kUniform7Type = GL_UNSIGNED_INT_VEC4;
+  static const GLenum kUniform8Type = GL_INT;
   static const GLenum kUniformSamplerExternalType = GL_SAMPLER_EXTERNAL_OES;
   static const GLenum kUniformCubemapType = GL_SAMPLER_CUBE;
   static const GLint kInvalidUniformLocation = 30;
   static const GLint kBadUniformIndex = 1000;
 
   static const GLint kOutputVariable1Size = 0;
   static const GLenum kOutputVariable1Type = GL_FLOAT_VEC4;
   static const GLuint kOutputVariable1ColorName = 7;
   static const GLuint kOutputVariable1Index = 0;
   static const char* kOutputVariable1Name;
@@ skipping 141 matching lines @@
 
  protected:
   void SetUp() override;
   void TearDown() override;
 };
 
 // SpecializedSetup specializations that are needed in multiple unittest files.
 template <>
 void GLES2DecoderTestBase::SpecializedSetup<cmds::LinkProgram, 0>(bool valid);
 
+MATCHER_P2(PointsToArray, array, size, "") {
+  for (size_t i = 0; i < static_cast<size_t>(size); ++i) {
+    if (arg[i] != array[i])
+      return false;
+  }
+  return true;
+}
+
 }  // namespace gles2
 }  // namespace gpu
 
 #endif  // GPU_COMMAND_BUFFER_SERVICE_GLES2_CMD_DECODER_UNITTEST_BASE_H_