Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 226423002: Merge 261120 "gpu: Lose context when BeginQueryEXT fails to allo..." (Closed)

Created:
6 years, 8 months ago by kareng
Modified:
6 years, 8 months ago
Reviewers:
danakj
CC:
chromium-reviews, viettrungluu+watch_chromium.org, Ian Vollick, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, abarth-chromium, ben+mojo_chromium.org, darin (slow to review)
Visibility:
Public.

Description

Merge 261120 "gpu: Lose context when BeginQueryEXT fails to allo..." > gpu: Lose context when BeginQueryEXT fails to allocate. > > Instead of crashes, raise a GL_OUT_OF_MEMORY error. Since compositor > does not want to deal with these errors and it would leave it in a > bad state, add the ability to lose the context when GL_OUT_OF_MEMORY > occurs. > > R=dmichael@chromium.org, jamesr@chromium.org, piman@chromium.org, piman > BUG=351587 > > Review URL: https://codereview.chromium.org/199443004 TBR=danakj@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261816

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+853 lines, -1027 lines) Patch
M content/browser/android/in_process/synchronous_compositor_factory_impl.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 2 chunks +4 lines, -1 line 0 comments Download
M content/browser/gpu/gpu_ipc_browsertests.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 chunk +4 lines, -1 line 0 comments Download
M content/browser/renderer_host/image_transport_factory_android.cc View 1 chunk +4 lines, -1 line 0 comments Download
M content/common/gpu/client/context_provider_command_buffer_browsertest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M content/common/gpu/client/gl_helper_benchmark.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/common/gpu/client/gl_helper_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/common/gpu/client/gpu_in_process_context_tests.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h View 4 chunks +18 lines, -14 lines 0 comments Download
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc View 6 chunks +22 lines, -13 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 3 chunks +6 lines, -1 line 0 comments Download
M content/renderer/render_widget.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/render_widget.cc View 4 chunks +28 lines, -28 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/test_context_provider_factory.cc View 1 chunk +3 lines, -1 line 0 comments Download
M gpu/command_buffer/client/gl_in_process_context.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/client/gl_in_process_context.cc View 4 chunks +9 lines, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_implementation.h View 3 chunks +9 lines, -11 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 5 chunks +15 lines, -16 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest.cc View 8 chunks +63 lines, -11 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils.cc View 3 chunks +19 lines, -13 lines 0 comments Download
M gpu/command_buffer/service/context_state.h View 2 chunks +4 lines, -1 line 0 comments Download
M gpu/command_buffer/service/context_state.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/error_state.h View 1 chunk +6 lines, -1 line 0 comments Download
M gpu/command_buffer/service/error_state.cc View 4 chunks +8 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 7 chunks +21 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 84 chunks +441 lines, -775 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 3 chunks +19 lines, -22 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 7 chunks +49 lines, -61 lines 0 comments Download
M gpu/command_buffer/tests/gl_manager.h View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/tests/gl_manager.cc View 2 chunks +9 lines, -8 lines 0 comments Download
M gpu/gles2_conform_support/egl/display.cc View 1 chunk +8 lines, -6 lines 0 comments Download
M mojo/examples/aura_demo/demo_context_factory.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M mojo/gles2/gles2_context.cc View 1 chunk +6 lines, -1 line 0 comments Download
M ppapi/shared_impl/ppb_graphics_3d_shared.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/compositor/test/in_process_context_factory.cc View 3 chunks +8 lines, -3 lines 0 comments Download
M webkit/common/gpu/context_provider_in_process.h View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/common/gpu/context_provider_in_process.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h View 3 chunks +5 lines, -1 line 0 comments Download
M webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc View 5 chunks +22 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kareng
6 years, 8 months ago (2014-04-04 18:58:46 UTC) #1
kareng
6 years, 8 months ago (2014-04-04 19:01:03 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r261816.

Powered by Google App Engine
This is Rietveld 408576698