Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: headless/lib/browser/headless_devtools_manager_delegate.cc

Issue 2263843002: DevTools: merge devtools target with devtools host, part 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: for landing 3 Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: headless/lib/browser/headless_devtools_manager_delegate.cc
diff --git a/headless/lib/browser/headless_devtools_manager_delegate.cc b/headless/lib/browser/headless_devtools_manager_delegate.cc
index 338c5cc90a347642182641d6acfce2c78a9bd202..adc2c5ef92ee1bd4a34dc58bf3c8cf08e72335a6 100644
--- a/headless/lib/browser/headless_devtools_manager_delegate.cc
+++ b/headless/lib/browser/headless_devtools_manager_delegate.cc
@@ -8,6 +8,7 @@
#include <utility>
#include "content/public/browser/browser_thread.h"
+#include "content/public/browser/devtools_agent_host.h"
#include "content/public/browser/web_contents.h"
#include "headless/lib/browser/headless_browser_context_impl.h"
#include "headless/lib/browser/headless_browser_impl.h"
@@ -61,6 +62,16 @@ base::DictionaryValue* HeadlessDevToolsManagerDelegate::HandleCommand(
return result.release();
}
+std::string HeadlessDevToolsManagerDelegate::GetTargetType(
+ content::RenderFrameHost* host) {
+ return content::DevToolsAgentHost::kTypePage;
+}
+
+std::string HeadlessDevToolsManagerDelegate::GetTargetTitle(
+ content::RenderFrameHost* host) {
+ return "";
+}
+
std::unique_ptr<base::Value> HeadlessDevToolsManagerDelegate::CreateTarget(
const base::DictionaryValue* params) {
std::string url;

Powered by Google App Engine
This is Rietveld 408576698