Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1299)

Unified Diff: content/browser/devtools/devtools_agent_host_impl.cc

Issue 2263843002: DevTools: merge devtools target with devtools host, part 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: for landing 3 Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/devtools_agent_host_impl.cc
diff --git a/content/browser/devtools/devtools_agent_host_impl.cc b/content/browser/devtools/devtools_agent_host_impl.cc
index 109dccd0976b10575a2da8af4ef673ccac31e8f5..fdd38d13c14ca9d1d392da80161aa31ebbc01ad0 100644
--- a/content/browser/devtools/devtools_agent_host_impl.cc
+++ b/content/browser/devtools/devtools_agent_host_impl.cc
@@ -7,7 +7,6 @@
#include <map>
#include <vector>
-#include "base/guid.h"
#include "base/json/json_writer.h"
#include "base/lazy_instance.h"
#include "content/browser/devtools/devtools_manager.h"
@@ -32,6 +31,14 @@ base::LazyInstance<AgentStateCallbacks>::Leaky g_callbacks =
LAZY_INSTANCE_INITIALIZER;
} // namespace
+char DevToolsAgentHost::kTypePage[] = "page";
+char DevToolsAgentHost::kTypeFrame[] = "frame";
+char DevToolsAgentHost::kTypeSharedWorker[] = "shared_worker";
+char DevToolsAgentHost::kTypeServiceWorker[] = "service_worker";
+char DevToolsAgentHost::kTypeExternal[] = "external";
+char DevToolsAgentHost::kTypeBrowser[] = "browser";
+char DevToolsAgentHost::kTypeOther[] = "other";
+
// static
std::string DevToolsAgentHost::GetProtocolVersion() {
return std::string(devtools::kProtocolVersion);
@@ -74,8 +81,11 @@ scoped_refptr<DevToolsAgentHost> DevToolsAgentHost::GetForWorker(
->GetDevToolsAgentHostForWorker(worker_process_id, worker_route_id);
}
-DevToolsAgentHostImpl::DevToolsAgentHostImpl()
- : id_(base::GenerateGUID()), session_id_(0), client_(NULL) {
+DevToolsAgentHostImpl::DevToolsAgentHostImpl(const std::string& id)
+ : id_(id),
+ session_id_(0),
+ description_(""),
+ client_(NULL) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
g_instances.Get()[id_] = this;
}
@@ -166,6 +176,27 @@ std::string DevToolsAgentHostImpl::GetId() {
return id_;
}
+std::string DevToolsAgentHostImpl::GetParentId() {
+ return "";
+}
+
+std::string DevToolsAgentHostImpl::GetDescription() {
+ return description_;
+}
+
+void DevToolsAgentHostImpl::SetDescriptionOverride(
+ const std::string& description) {
+ description_ = description;
+}
+
+GURL DevToolsAgentHostImpl::GetFaviconURL() {
+ return GURL();
+}
+
+base::TimeTicks DevToolsAgentHostImpl::GetLastActivityTime() {
+ return base::TimeTicks();
+}
+
BrowserContext* DevToolsAgentHostImpl::GetBrowserContext() {
return nullptr;
}
@@ -180,6 +211,15 @@ void DevToolsAgentHostImpl::DisconnectWebContents() {
void DevToolsAgentHostImpl::ConnectWebContents(WebContents* wc) {
}
+bool DevToolsAgentHostImpl::Inspect() {
+ DevToolsManager* manager = DevToolsManager::GetInstance();
+ if (manager->delegate()) {
+ manager->delegate()->Inspect(this);
+ return true;
+ }
+ return false;
+}
+
void DevToolsAgentHostImpl::SendProtocolResponse(int session_id,
const std::string& message) {
SendMessageToClient(session_id, message);
@@ -266,15 +306,6 @@ void DevToolsAgentHostImpl::NotifyCallbacks(
(*it)->Run(agent_host, attached);
}
-bool DevToolsAgentHostImpl::Inspect(BrowserContext* browser_context) {
- DevToolsManager* manager = DevToolsManager::GetInstance();
- if (manager->delegate()) {
- manager->delegate()->Inspect(browser_context, this);
- return true;
- }
- return false;
-}
-
// DevToolsMessageChunkProcessor -----------------------------------------------
DevToolsMessageChunkProcessor::DevToolsMessageChunkProcessor(
« no previous file with comments | « content/browser/devtools/devtools_agent_host_impl.h ('k') | content/browser/devtools/devtools_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698