chrome/browser/autocomplete/history_quick_provider.cc - Issue 226283009: Make AutocompleteInput::Parse() more strict: return QUERY for all inputs that

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/history_quick_provider.cc

Issue 226283009: Make AutocompleteInput::Parse() more strict: return QUERY for all inputs that (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autocomplete/autocomplete_input_unittest.cc ('k') | chrome/browser/autocomplete/history_url_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autocomplete/history_quick_provider.cc

===================================================================

--- chrome/browser/autocomplete/history_quick_provider.cc (revision 261885)

+++ chrome/browser/autocomplete/history_quick_provider.cc (working copy)

@@ -124,9 +124,7 @@

// provider won't promote the URL-what-you-typed match to first

// for these inputs.

const bool can_have_url_what_you_typed_match_first =

- autocomplete_input_.canonicalized_url().is_valid() &&

(autocomplete_input_.type() != AutocompleteInput::QUERY) &&

- (autocomplete_input_.type() != AutocompleteInput::FORCED_QUERY) &&

Mark P 2014/04/25 02:59:20 Why did you remove this?

Mark P 2014/04/25 03:00:29 Nevermind, I see that we wouldn't reach here in FO

(!autocomplete_input_.parts().username.is_nonempty() ||

autocomplete_input_.parts().password.is_nonempty() ||

autocomplete_input_.parts().path.is_nonempty());

« no previous file with comments | « chrome/browser/autocomplete/autocomplete_input_unittest.cc ('k') | chrome/browser/autocomplete/history_url_provider.cc » ('j') | no next file with comments »