chrome/browser/autocomplete/autocomplete_input_unittest.cc - Issue 226283009: Make AutocompleteInput::Parse() more strict: return QUERY for all inputs that

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/autocomplete_input_unittest.cc

Issue 226283009: Make AutocompleteInput::Parse() more strict: return QUERY for all inputs that (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autocomplete/autocomplete_input.cc ('k') | chrome/browser/autocomplete/history_quick_provider.cc » ('j') | chrome/browser/autocomplete/history_quick_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autocomplete/autocomplete_input_unittest.cc

===================================================================

--- chrome/browser/autocomplete/autocomplete_input_unittest.cc (revision 261885)

+++ chrome/browser/autocomplete/autocomplete_input_unittest.cc (working copy)

@@ -33,6 +33,7 @@

{ ASCIIToUTF16("foo.-com"), AutocompleteInput::QUERY },

{ ASCIIToUTF16("foo/"), AutocompleteInput::URL },

{ ASCIIToUTF16("foo/bar"), AutocompleteInput::UNKNOWN },

+ { ASCIIToUTF16("foo/bar%00"), AutocompleteInput::QUERY },

{ ASCIIToUTF16("foo/bar/"), AutocompleteInput::URL },

{ ASCIIToUTF16("foo/bar baz\\"), AutocompleteInput::URL },

{ ASCIIToUTF16("foo.com/bar"), AutocompleteInput::URL },

@@ -87,6 +88,7 @@

{ ASCIIToUTF16("http://foo.c"), AutocompleteInput::URL },

{ ASCIIToUTF16("http://foo.com"), AutocompleteInput::URL },

{ ASCIIToUTF16("http://foo_bar.com"), AutocompleteInput::URL },

+ { ASCIIToUTF16("http://foo/bar%00"), AutocompleteInput::QUERY },

{ ASCIIToUTF16("http://foo/bar baz"), AutocompleteInput::URL },

{ ASCIIToUTF16("http://-foo.com"), AutocompleteInput::URL },

{ ASCIIToUTF16("http://foo-.com"), AutocompleteInput::URL },

@@ -121,6 +123,8 @@

{ ASCIIToUTF16("chrome-search://"), AutocompleteInput::QUERY },

{ ASCIIToUTF16("chrome-devtools:"), AutocompleteInput::QUERY },

{ ASCIIToUTF16("about://f;"), AutocompleteInput::QUERY },

+ { ASCIIToUTF16("://w"), AutocompleteInput::QUERY },

+ { ASCIIToUTF16(":w"), AutocompleteInput::QUERY },

};

for (size_t i = 0; i < ARRAYSIZE_UNSAFE(input_cases); ++i) {