Make AutocompleteInput::Parse() more strict: return QUERY for all inputs that

chrome/browser/autocomplete/history_quick_provider.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autocomplete/history_quick_provider.h"
 
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/command_line.h"
@@ skipping 106 matching lines @@
   int url_what_you_typed_match_score = -1;  // undefined
   // These are necessary (but not sufficient) conditions for the omnibox
   // input to be a URL-what-you-typed match.  The username test checks that
   // either the username does not exist (a regular URL such as http://site/)
   // or, if the username exists (http://user@site/), there must be either
   // a password or a port.  Together these exclude pure username@site
   // inputs because these are likely to be an e-mail address.  HistoryURL
   // provider won't promote the URL-what-you-typed match to first
   // for these inputs.
   const bool can_have_url_what_you_typed_match_first =
-      autocomplete_input_.canonicalized_url().is_valid() &&
       (autocomplete_input_.type() != AutocompleteInput::QUERY) &&
-      (autocomplete_input_.type() != AutocompleteInput::FORCED_QUERY) &&

[Mark P, 2014/04/25 02:59:20]

Why did you remove this?

[Mark P, 2014/04/25 03:00:29]

Nevermind, I see that we wouldn't reach here in FORCED_QUERY mode.

       (!autocomplete_input_.parts().username.is_nonempty() ||
        autocomplete_input_.parts().password.is_nonempty() ||
        autocomplete_input_.parts().path.is_nonempty());
   if (can_have_url_what_you_typed_match_first) {
     HistoryService* const history_service =
         HistoryServiceFactory::GetForProfile(profile_,
                                              Profile::EXPLICIT_ACCESS);
     // We expect HistoryService to be available.  In case it's not,
     // (e.g., due to Profile corruption) we let HistoryQuick provider
     // completions (which may be available because it's a different
@@ skipping 169 matching lines @@
   if (index_for_testing_.get())
     return index_for_testing_.get();
 
   HistoryService* const history_service =
       HistoryServiceFactory::GetForProfile(profile_, Profile::EXPLICIT_ACCESS);
   if (!history_service)
     return NULL;
 
   return history_service->InMemoryIndex();
 }