Revert of bluetooth: Return false for IsPresent only when bluetooth is not supported

Revert of bluetooth: Return false for IsPresent only when bluetooth is not supported (patchset #1 id:1 of https://codereview.chromium.org/2248033006/ )

Reason for revert:
device_unittests: BluetoothTest.ConstructDefaultAdapter is failing.

Original issue's description:
> bluetooth: Return false for IsPresent only when bluetooth is not supported
>
> BUG=633274
>
> Committed: https://crrev.com/784971913adcc32bdb22a92da6ac237a7de88a2b
> Cr-Commit-Position: refs/heads/master@{#413192}

TBR=jyasskin@chromium.org,ortuno@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=633274
Committed: https://crrev.com/7f007849dc7d77512307a59341fb2d35a1a0ee51
Cr-Commit-Position: refs/heads/master@{#413402}

[tasak, 2016-08-22 02:50:45]

The CQ bit was checked by tasak@google.com

[tasak, 2016-08-22 02:50:45]

Created Revert of bluetooth: Return false for IsPresent only when bluetooth is
not supported

[commit-bot: I haz the power, 2016-08-22 02:50:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 04:05:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-22 04:07:43]

Description was changed from

==========
Revert of bluetooth: Return false for IsPresent only when bluetooth is not
supported (patchset #1 id:1 of https://codereview.chromium.org/2248033006/ )

Reason for revert:
device_unittests: BluetoothTest.ConstructDefaultAdapter is failing.

Original issue's description:
> bluetooth: Return false for IsPresent only when bluetooth is not supported
> 
> BUG=633274
> 
> Committed: https://crrev.com/784971913adcc32bdb22a92da6ac237a7de88a2b
> Cr-Commit-Position: refs/heads/master@{#413192}

TBR=jyasskin@chromium.org,ortuno@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=633274
==========

to

==========
Revert of bluetooth: Return false for IsPresent only when bluetooth is not
supported (patchset #1 id:1 of https://codereview.chromium.org/2248033006/ )

Reason for revert:
device_unittests: BluetoothTest.ConstructDefaultAdapter is failing.

Original issue's description:
> bluetooth: Return false for IsPresent only when bluetooth is not supported
>
> BUG=633274
>
> Committed: https://crrev.com/784971913adcc32bdb22a92da6ac237a7de88a2b
> Cr-Commit-Position: refs/heads/master@{#413192}

TBR=jyasskin@chromium.org,ortuno@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=633274

Committed: https://crrev.com/7f007849dc7d77512307a59341fb2d35a1a0ee51
Cr-Commit-Position: refs/heads/master@{#413402}
==========

[commit-bot: I haz the power, 2016-08-22 04:07:44]

Patchset 1 (id:??) landed as
https://crrev.com/7f007849dc7d77512307a59341fb2d35a1a0ee51
Cr-Commit-Position: refs/heads/master@{#413402}

[Jeffrey Yasskin, 2016-08-22 15:24:54]

On 2016/08/22 04:07:44, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/7f007849dc7d77512307a59341fb2d35a1a0ee51
> Cr-Commit-Position: refs/heads/master@{#413402}

On which bot is it failing?

[tasak, 2016-08-24 02:24:33]

On 2016/08/22 15:24:54, Jeffrey Yasskin wrote:
> On 2016/08/22 04:07:44, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/7f007849dc7d77512307a59341fb2d35a1a0ee51
> > Cr-Commit-Position: refs/heads/master@{#413402}
> 
> On which bot is it failing?

Mac10.11 Tests and Mac10.10 Tests
https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests
https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests

e.g.
https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/2491
failures:
BluetoothTest.ConstructDefaultAdapter

[ RUN      ] BluetoothTest.ConstructDefaultAdapter
../../device/bluetooth/bluetooth_adapter_unittest.cc:433: Failure
Expected: (adapter_->GetAddress().length()) > (0u), actual: 0 vs 0
../../device/bluetooth/bluetooth_adapter_unittest.cc:434: Failure
Expected: (adapter_->GetName().length()) > (0u), actual: 0 vs 0
[  FAILED  ] BluetoothTest.ConstructDefaultAdapter (3 ms)

[Jeffrey Yasskin, 2016-08-24 02:53:32]

Thanks!

On Tue, Aug 23, 2016 at 7:24 PM, <tasak@google.com> wrote:

> On 2016/08/22 15:24:54, Jeffrey Yasskin wrote:
> > On 2016/08/22 04:07:44, commit-bot: I haz the power wrote:
> > > Patchset 1 (id:??) landed as
> > > https://crrev.com/7f007849dc7d77512307a59341fb2d35a1a0ee51
> > > Cr-Commit-Position: refs/heads/master@{#413402}
> >
> > On which bot is it failing?
>
> Mac10.11 Tests and Mac10.10 Tests
> https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests
> https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests
>
> e.g.
> https://build.chromium.org/p/chromium.mac/builders/Mac10.
> 11%20Tests/builds/2491
> failures:
> BluetoothTest.ConstructDefaultAdapter
>
> [ RUN ] BluetoothTest.ConstructDefaultAdapter
> ../../device/bluetooth/bluetooth_adapter_unittest.cc:433: Failure
> Expected: (adapter_->GetAddress().length()) > (0u), actual: 0 vs 0
> ../../device/bluetooth/bluetooth_adapter_unittest.cc:434: Failure
> Expected: (adapter_->GetName().length()) > (0u), actual: 0 vs 0
> [ FAILED ] BluetoothTest.ConstructDefaultAdapter (3 ms)
>
>
> https://codereview.chromium.org/2262033002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.