Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 2248033006: bluetooth: Return false for IsPresent only when bluetooth is not supported (Closed)

Created:
4 years, 4 months ago by ortuno
Modified:
4 years, 4 months ago
Reviewers:
Jeffrey Yasskin
CC:
chromium-reviews, ortuno+watch_chromium.org, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Return false for IsPresent only when bluetooth is not supported BUG=633274 Committed: https://crrev.com/784971913adcc32bdb22a92da6ac237a7de88a2b Committed: https://crrev.com/80936aa92bb2c378fb3729f67b1e35712920282a Cr-Original-Commit-Position: refs/heads/master@{#413192} Cr-Commit-Position: refs/heads/master@{#413589}

Patch Set 1 #

Patch Set 2 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M device/bluetooth/bluetooth_adapter_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_unittest.cc View 1 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
ortuno
jyasskin: PTAL
4 years, 4 months ago (2016-08-17 23:00:00 UTC) #3
Jeffrey Yasskin
lgtm
4 years, 4 months ago (2016-08-19 17:08:41 UTC) #7
ortuno
Thanks!
4 years, 4 months ago (2016-08-19 17:10:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248033006/1
4 years, 4 months ago (2016-08-19 17:10:46 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-19 18:28:30 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/784971913adcc32bdb22a92da6ac237a7de88a2b Cr-Commit-Position: refs/heads/master@{#413192}
4 years, 4 months ago (2016-08-19 18:30:18 UTC) #13
tasak
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2262033002/ by tasak@google.com. ...
4 years, 4 months ago (2016-08-22 02:50:45 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248033006/20001
4 years, 4 months ago (2016-08-22 22:44:21 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-23 00:05:22 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 00:08:07 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/80936aa92bb2c378fb3729f67b1e35712920282a
Cr-Commit-Position: refs/heads/master@{#413589}

Powered by Google App Engine
This is Rietveld 408576698