Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2261703003: [MD settings] add ripple back to advanced settings menu (Closed)

Created:
4 years, 4 months ago by dschuyler
Modified:
4 years, 4 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] add ripple back to advanced settings menu This CL re-adds the ripple effect to the Advanced toggle in the side nav menu. BUG=639543 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/4f1e9640dbd205897b8d1b7c714f4eabb6da11b6 Cr-Commit-Position: refs/heads/master@{#413517}

Patch Set 1 : closure fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M chrome/browser/resources/settings/settings_menu/settings_menu.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/settings_menu/settings_menu.js View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
dschuyler
4 years, 4 months ago (2016-08-20 01:30:12 UTC) #8
tommycli
lgtm
4 years, 4 months ago (2016-08-20 01:39:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2261703003/20001
4 years, 4 months ago (2016-08-22 18:14:20 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 4 months ago (2016-08-22 19:56:41 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 19:59:16 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f1e9640dbd205897b8d1b7c714f4eabb6da11b6
Cr-Commit-Position: refs/heads/master@{#413517}

Powered by Google App Engine
This is Rietveld 408576698