Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4386)

Unified Diff: chrome/browser/resources/settings/settings_menu/settings_menu.js

Issue 2261703003: [MD settings] add ripple back to advanced settings menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: closure fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/settings_menu/settings_menu.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/settings_menu/settings_menu.js
diff --git a/chrome/browser/resources/settings/settings_menu/settings_menu.js b/chrome/browser/resources/settings/settings_menu/settings_menu.js
index 494228bfc6e777dd828c4b265df02f957c7dcdbf..dd66609cf9564896c5e422e4788bccdc9ef29f9f 100644
--- a/chrome/browser/resources/settings/settings_menu/settings_menu.js
+++ b/chrome/browser/resources/settings/settings_menu/settings_menu.js
@@ -43,15 +43,15 @@ Polymer({
},
/**
- * @param {!Node} target
+ * @param {!Event} event
* @private
*/
- ripple_: function(target) {
+ ripple_: function(event) {
var ripple = document.createElement('paper-ripple');
ripple.addEventListener('transitionend', function() {
ripple.remove();
});
- target.appendChild(ripple);
+ event.currentTarget.appendChild(ripple);
ripple.downAction();
ripple.upAction();
},
@@ -61,8 +61,6 @@ Polymer({
* @private
*/
openPage_: function(event) {
- this.ripple_(/** @type {!Node} */(event.currentTarget));
-
var route = settings.getRouteForPath(event.currentTarget.dataset.path);
assert(route, 'settings-menu has an an entry with an invalid path');
settings.navigateTo(route);
« no previous file with comments | « chrome/browser/resources/settings/settings_menu/settings_menu.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698