chrome/browser/resources/settings/settings_menu/settings_menu.html - Issue 2261703003: [MD settings] add ripple back to advanced settings menu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_menu/settings_menu.html

Issue 2261703003: [MD settings] add ripple back to advanced settings menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: closure fix Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/settings/settings_menu/settings_menu.html

diff --git a/chrome/browser/resources/settings/settings_menu/settings_menu.html b/chrome/browser/resources/settings/settings_menu/settings_menu.html

index 185935fb66f55bd211b55ee530725cb4de2619ab..2e41a59eab86bcacaec233b08d59eed540a4a240 100644

--- a/chrome/browser/resources/settings/settings_menu/settings_menu.html

+++ b/chrome/browser/resources/settings/settings_menu/settings_menu.html

@@ -134,7 +134,7 @@

<paper-submenu class="page-menu" id="advancedPage" actionable

opened="{{advancedOpened_}}"

hidden="[[!pageVisibility.advancedSettings]]">

- <div class="menu-trigger">

+ <div class="menu-trigger" on-tap="ripple_">

<span>$i18n{advancedPageTitle}</span>

<iron-icon icon="[[arrowState_(advancedOpened_)]]"></iron-icon>

</div>

« no previous file with comments | « no previous file | chrome/browser/resources/settings/settings_menu/settings_menu.js » ('j') | no next file with comments »