Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2261523006: Disallow non-namespaced use of base::Version. (Closed)

Created:
4 years, 4 months ago by pwnall
Modified:
4 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disallow non-namespaced use of base::Version. BUG=639416 Committed: https://crrev.com/0de2231894d4289190b8661ae40f9a6cc29fc910 Cr-Commit-Position: refs/heads/master@{#415626}

Patch Set 1 : Rebased against master. #

Patch Set 2 : Fixed newly introduced use of base::Version. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M base/version.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (14 generated)
pwnall
PTAL
4 years, 3 months ago (2016-08-31 02:39:53 UTC) #12
Nico
lgtm :-)
4 years, 3 months ago (2016-08-31 14:15:04 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2261523006/40001
4 years, 3 months ago (2016-08-31 14:15:23 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 3 months ago (2016-08-31 14:18:59 UTC) #17
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/0de2231894d4289190b8661ae40f9a6cc29fc910 Cr-Commit-Position: refs/heads/master@{#415626}
4 years, 3 months ago (2016-08-31 14:20:47 UTC) #19
battre
4 years, 3 months ago (2016-08-31 14:44:43 UTC) #20
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.chromium.org/2296703005/ by battre@chromium.org.

The reason for reverting is: Mac builders fail. See http://crbug.com/639416#c11.

Powered by Google App Engine
This is Rietveld 408576698