base/version.h - Issue 2261523006: Disallow non-namespaced use of base::Version.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/version.h

Issue 2261523006: Disallow non-namespaced use of base::Version. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed newly introduced use of base::Version. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/version.h

diff --git a/base/version.h b/base/version.h

index d044b2c394ebd62b1b00562a218097b8e22e7a0d..b3a0956bbe32f9a382c2dbb25c4042d2ebac4a9f 100644

--- a/base/version.h

+++ b/base/version.h

@@ -73,8 +73,4 @@ BASE_EXPORT std::ostream& operator<<(std::ostream& stream, const Version& v);

} // namespace base

-// TODO(xhwang) remove this when all users are updated to explicitly use the

-// namespace

-using base::Version;

#endif // BASE_VERSION_H_

« no previous file with comments | « no previous file | chrome/browser/policy/policy_browsertest.cc » ('j') | no next file with comments »