chrome/browser/policy/policy_browsertest.cc - Issue 2261523006: Disallow non-namespaced use of base::Version.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/policy_browsertest.cc

Issue 2261523006: Disallow non-namespaced use of base::Version. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed newly introduced use of base::Version. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/policy/policy_browsertest.cc

diff --git a/chrome/browser/policy/policy_browsertest.cc b/chrome/browser/policy/policy_browsertest.cc

index 94e0a495987c8d806527b6d95895e96d5a4f4cc7..36bd78ee1cdb0eac8995b101c8f054e5023573bc 100644

--- a/chrome/browser/policy/policy_browsertest.cc

+++ b/chrome/browser/policy/policy_browsertest.cc

@@ -3807,7 +3807,7 @@ update_client::CrxComponent ComponentUpdaterPolicyTest::MakeCrxComponent(

// The component uses HTTPS only for network interception purposes.

update_client::CrxComponent crx_component;

crx_component.pk_hash.assign(std::begin(jebg_hash), std::end(jebg_hash));

- crx_component.version = Version("0.9");

+ crx_component.version = base::Version("0.9");

crx_component.installer = scoped_refptr<MockInstaller>(new MockInstaller());

crx_component.requires_network_encryption = true;

crx_component.supports_group_policy_enable_component_updates =

« no previous file with comments | « base/version.h ('k') | no next file » | no next file with comments »