third_party/WebKit/Source/modules/notifications/NotificationOptions.idl - Issue 2261283002: Add Notification images (Blink + desktop implementation)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/NotificationOptions.idl

Issue 2261283002: Add Notification images (Blink + desktop implementation) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Check IPC drawsNothing rather than isNull Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp ('k') | third_party/WebKit/Source/modules/notifications/NotificationResourcesLoader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/NotificationOptions.idl

diff --git a/third_party/WebKit/Source/modules/notifications/NotificationOptions.idl b/third_party/WebKit/Source/modules/notifications/NotificationOptions.idl

index 5657d9af7e12f96fee80265d1d77c0adfb095d5f..09b6dc9d62c662e68aeae7ca3e436a31ccfcbb5f 100644

--- a/third_party/WebKit/Source/modules/notifications/NotificationOptions.idl

+++ b/third_party/WebKit/Source/modules/notifications/NotificationOptions.idl

@@ -15,6 +15,7 @@ dictionary NotificationOptions {

DOMString lang = "";

DOMString body = "";

DOMString tag = "";

+ [RuntimeEnabled=NotificationImage] USVString image;

USVString icon;

[RuntimeEnabled=NotificationBadge] USVString badge;

// TODO(sh919.park): vibrate should be ([Clamp] unsigned long or sequence<unsigned long>)