third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp - Issue 2261283002: Add Notification images (Blink + desktop implementation)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp

Issue 2261283002: Add Notification images (Blink + desktop implementation) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Check IPC drawsNothing rather than isNull Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/notifications/NotificationData.cpp ('k') | third_party/WebKit/Source/modules/notifications/NotificationOptions.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp

diff --git a/third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp b/third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp

index dd9799f3cd2389f06aa0e4af3701e44d5f9500ab..7d50c507514efdad48f451519652eddec33904ab 100644

--- a/third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp

+++ b/third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp

@@ -23,6 +23,7 @@ const char kNotificationLang[] = "nl";

const char kNotificationBody[] = "Hello, world";

const char kNotificationTag[] = "my_tag";

const char kNotificationEmptyTag[] = "";

+const char kNotificationImage[] = "https://example.com/image.jpg";

const char kNotificationIcon[] = "https://example.com/icon.png";

const char kNotificationIconInvalid[] = "https://invalid:icon:url";

const char kNotificationBadge[] = "https://example.com/badge.png";

@@ -81,6 +82,7 @@ TEST_F(NotificationDataTest, ReflectProperties)

options.setLang(kNotificationLang);

options.setBody(kNotificationBody);

options.setTag(kNotificationTag);

+ options.setImage(kNotificationImage);

options.setIcon(kNotificationIcon);

options.setBadge(kNotificationBadge);

options.setVibrate(vibrationSequence);

@@ -185,6 +187,7 @@ TEST_F(NotificationDataTest, InvalidIconUrls)

}

NotificationOptions options;

+ options.setImage(kNotificationIconInvalid);

options.setIcon(kNotificationIconInvalid);

options.setBadge(kNotificationIconInvalid);

options.setActions(actions);

@@ -193,6 +196,7 @@ TEST_F(NotificationDataTest, InvalidIconUrls)

WebNotificationData notificationData = createWebNotificationData(getExecutionContext(), kNotificationTitle, options, exceptionState);

ASSERT_FALSE(exceptionState.hadException());

+ EXPECT_TRUE(notificationData.image.isEmpty());

EXPECT_TRUE(notificationData.icon.isEmpty());

EXPECT_TRUE(notificationData.badge.isEmpty());

for (const auto& action : notificationData.actions)