third_party/WebKit/Source/modules/notifications/NotificationResourcesLoader.h - Issue 2261283002: Add Notification images (Blink + desktop implementation)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/NotificationResourcesLoader.h

Issue 2261283002: Add Notification images (Blink + desktop implementation) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Check IPC drawsNothing rather than isNull Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/notifications/NotificationOptions.idl ('k') | third_party/WebKit/Source/modules/notifications/NotificationResourcesLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/NotificationResourcesLoader.h

diff --git a/third_party/WebKit/Source/modules/notifications/NotificationResourcesLoader.h b/third_party/WebKit/Source/modules/notifications/NotificationResourcesLoader.h

index 238a53d2fd5a2d368033c94bdaa859729071f667..cdb493c0e4a1cd932487fa88c75756c2443d7b0f 100644

--- a/third_party/WebKit/Source/modules/notifications/NotificationResourcesLoader.h

+++ b/third_party/WebKit/Source/modules/notifications/NotificationResourcesLoader.h

@@ -54,6 +54,7 @@ public:

private:

void loadImage(ExecutionContext*, const KURL&, std::unique_ptr<NotificationImageLoader::ImageCallback>);

+ void didLoadImage(const SkBitmap& image);

void didLoadIcon(const SkBitmap& image);

void didLoadBadge(const SkBitmap& image);

void didLoadActionIcon(size_t actionIndex, const SkBitmap& image);

@@ -66,6 +67,7 @@ private:

std::unique_ptr<CompletionCallback> m_completionCallback;

int m_pendingRequestCount;

HeapVector<Member<NotificationImageLoader>> m_imageLoaders;

+ SkBitmap m_image;

SkBitmap m_icon;

SkBitmap m_badge;

Vector<SkBitmap> m_actionIcons;