content/browser/notifications/notification_database_data.proto - Issue 2261283002: Add Notification images (Blink + desktop implementation)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/notifications/notification_database_data.proto

Issue 2261283002: Add Notification images (Blink + desktop implementation) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Check IPC drawsNothing rather than isNull Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/notifications/platform_notification_service.html ('k') | content/browser/notifications/notification_database_data_conversions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/notifications/notification_database_data.proto

diff --git a/content/browser/notifications/notification_database_data.proto b/content/browser/notifications/notification_database_data.proto

index aad02a8cf2a5e6df6dfab81aa328c24e4e4afc26..a3190338c966f3d112d581b6b1343b38844ec78d 100644

--- a/content/browser/notifications/notification_database_data.proto

+++ b/content/browser/notifications/notification_database_data.proto

@@ -38,7 +38,7 @@ message NotificationDatabaseDataProto {

// Actual data payload of the notification. This message is the protocol

// buffer meant to serialize the content::PlatformNotificationData structure.

- // Next tag: 15

+ // Next tag: 16

message NotificationData {

enum Direction {

LEFT_TO_RIGHT = 0;

@@ -51,6 +51,7 @@ message NotificationDatabaseDataProto {

optional string lang = 3;

optional string body = 4;

optional string tag = 5;

+ optional string image = 15;

optional string icon = 6;

optional string badge = 14;

repeated int32 vibration_pattern = 9 [packed=true];