chrome/test/data/notifications/platform_notification_service.html - Issue 2261283002: Add Notification images (Blink + desktop implementation)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/notifications/platform_notification_service.html

Issue 2261283002: Add Notification images (Blink + desktop implementation) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Check IPC drawsNothing rather than isNull Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/platform_notification_service_interactive_uitest.cc ('k') | content/browser/notifications/notification_database_data.proto » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/notifications/platform_notification_service.html

diff --git a/chrome/test/data/notifications/platform_notification_service.html b/chrome/test/data/notifications/platform_notification_service.html

index 9e53c976e7fdaaf60ac29a469826373fa4c226b6..60e476342a9ca0bbd51598cc59656f63d55bbf93 100644

--- a/chrome/test/data/notifications/platform_notification_service.html

+++ b/chrome/test/data/notifications/platform_notification_service.html

@@ -53,6 +53,7 @@

lang: 'nl-NL',

body: 'Contents',

tag: 'replace-id',

+ image: 'icon.png',

icon: 'icon.png',

badge: 'icon.png',

timestamp: 621046800000,