content/browser/notifications/notification_database_data_conversions.cc - Issue 2261283002: Add Notification images (Blink + desktop implementation)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/notifications/notification_database_data_conversions.cc

Issue 2261283002: Add Notification images (Blink + desktop implementation) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Check IPC drawsNothing rather than isNull Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/notifications/notification_database_data.proto ('k') | content/browser/notifications/notification_database_data_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/notifications/notification_database_data_conversions.cc

diff --git a/content/browser/notifications/notification_database_data_conversions.cc b/content/browser/notifications/notification_database_data_conversions.cc

index 381f0d3ef9c24eb83ade721a6a2a4853ca972310..e95d912bb0f949b279e80d3e582f1a0c7eb06fe9 100644

--- a/content/browser/notifications/notification_database_data_conversions.cc

+++ b/content/browser/notifications/notification_database_data_conversions.cc

@@ -52,6 +52,7 @@ bool DeserializeNotificationDatabaseData(const std::string& input,

notification_data->lang = payload.lang();

notification_data->body = base::UTF8ToUTF16(payload.body());

notification_data->tag = payload.tag();

+ notification_data->image = GURL(payload.image());

notification_data->icon = GURL(payload.icon());

notification_data->badge = GURL(payload.badge());

@@ -127,6 +128,7 @@ bool SerializeNotificationDatabaseData(const NotificationDatabaseData& input,

payload->set_lang(notification_data.lang);

payload->set_body(base::UTF16ToUTF8(notification_data.body));

payload->set_tag(notification_data.tag);

+ payload->set_image(notification_data.image.spec());

payload->set_icon(notification_data.icon.spec());

payload->set_badge(notification_data.badge.spec());