chrome/browser/notifications/platform_notification_service_interactive_uitest.cc - Issue 2261283002: Add Notification images (Blink + desktop implementation)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/platform_notification_service_interactive_uitest.cc

Issue 2261283002: Add Notification images (Blink + desktop implementation) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Check IPC drawsNothing rather than isNull Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/platform_notification_service_impl.cc ('k') | chrome/test/data/notifications/platform_notification_service.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/platform_notification_service_interactive_uitest.cc

diff --git a/chrome/browser/notifications/platform_notification_service_interactive_uitest.cc b/chrome/browser/notifications/platform_notification_service_interactive_uitest.cc

index 2d365a86f2d581f762ceb9d76ae5d26e87f9af5c..2c53937e1233bc5498a13a76678d076b908128c2 100644

--- a/chrome/browser/notifications/platform_notification_service_interactive_uitest.cc

+++ b/chrome/browser/notifications/platform_notification_service_interactive_uitest.cc

@@ -267,6 +267,7 @@ IN_PROC_BROWSER_TEST_F(PlatformNotificationServiceBrowserTest,

EXPECT_EQ("Some title", base::UTF16ToUTF8(default_notification.title()));

EXPECT_EQ("", base::UTF16ToUTF8(default_notification.message()));

EXPECT_EQ("", default_notification.tag());

+ EXPECT_TRUE(default_notification.image().IsEmpty());

EXPECT_TRUE(default_notification.icon().IsEmpty());

EXPECT_TRUE(default_notification.small_image().IsEmpty());

EXPECT_FALSE(default_notification.renotify());

@@ -294,6 +295,9 @@ IN_PROC_BROWSER_TEST_F(PlatformNotificationServiceBrowserTest,

EXPECT_EQ("Title", base::UTF16ToUTF8(all_options_notification.title()));

EXPECT_EQ("Contents", base::UTF16ToUTF8(all_options_notification.message()));

EXPECT_EQ("replace-id", all_options_notification.tag());

+ EXPECT_FALSE(all_options_notification.image().IsEmpty());

+ EXPECT_EQ(kIconWidth, all_options_notification.image().Width());

+ EXPECT_EQ(kIconHeight, all_options_notification.image().Height());

EXPECT_FALSE(all_options_notification.icon().IsEmpty());

EXPECT_EQ(kIconWidth, all_options_notification.icon().Width());

EXPECT_EQ(kIconHeight, all_options_notification.icon().Height());