content/browser/notifications/type_converters_unittest.cc - Issue 2261283002: Add Notification images (Blink + desktop implementation)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/notifications/type_converters_unittest.cc

Issue 2261283002: Add Notification images (Blink + desktop implementation) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/notifications/notification_message_filter.cc ('K') | « content/browser/notifications/type_converters.cc ('k') | content/child/notifications/notification_data_conversions.cc » ('j') | third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/notifications/type_converters_unittest.cc

diff --git a/content/browser/notifications/type_converters_unittest.cc b/content/browser/notifications/type_converters_unittest.cc

index 8c946a169c14f41eb4eaeafd63bfc750c9eefee9..d665efcd80696b5c857e0a7a2f6c0882a8813cab 100644

--- a/content/browser/notifications/type_converters_unittest.cc

+++ b/content/browser/notifications/type_converters_unittest.cc

@@ -20,6 +20,7 @@ TEST(NotificationTypeConvertersTest, TestConversion) {

notification_data.lang = "lang";

notification_data.body = base::ASCIIToUTF16("My Body");

notification_data.tag = "tag";

+ notification_data.image = GURL("https://example.com/image");

notification_data.icon = GURL("https://example.com/icon");

notification_data.badge = GURL("https://example.com/badge");

notification_data.vibration_pattern.push_back(42);

@@ -59,6 +60,7 @@ TEST(NotificationTypeConvertersTest, TestConversion) {

EXPECT_EQ(notification_data.lang, copied_notification_data.lang);

EXPECT_EQ(notification_data.body, copied_notification_data.body);

EXPECT_EQ(notification_data.tag, copied_notification_data.tag);

+ EXPECT_EQ(notification_data.image, copied_notification_data.image);

EXPECT_EQ(notification_data.icon, copied_notification_data.icon);

EXPECT_EQ(notification_data.badge, copied_notification_data.badge);

EXPECT_EQ(notification_data.vibration_pattern,